[chronojump/optimizeRFD] One comment for last commit



commit efbd263a7289fd88cb5d4341e66748f20203c754
Author: Xavier de Blas <xaviblas gmail com>
Date:   Fri Jan 1 19:25:56 2021 +0100

    One comment for last commit

 src/json/json.cs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
---
diff --git a/src/json/json.cs b/src/json/json.cs
index ee1acd4be..189476173 100644
--- a/src/json/json.cs
+++ b/src/json/json.cs
@@ -248,7 +248,11 @@ public class Json
 
                        string copyTo = Path.Combine(News.GetNewsDir(), code.ToString() + extension);
 
-                       //download the image if (1 version has changed OR 2 linkServerImage has changed OR 3 
image does not exists locally)
+                       /*
+                        * download the image if (1 version has changed OR 2 linkServerImage has changed OR 3 
image does not exists locally)
+                        * but note is much better to CHANGE ALSO THE VERSION if the linkServerImage has 
changed
+                        * if version does not change, maybe local db url never changes forcing the client to 
redownload the image every time Chronojump is opened
+                        */
                        bool needToDownloadImage = false;
                        foreach(News newsAtDB in newsAtDB_l)
                                if( newsAtJson.Code == newsAtDB.Code &&


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]