[gjs: 4/9] context: Remove JSAPI annotation from GjsContextPrivate::eval()




commit 2593b3a262d184f97a5ac270c927bed8fb115972
Author: Philip Chimento <philip chimento gmail com>
Date:   Thu Dec 10 15:51:24 2020 -0800

    context: Remove JSAPI annotation from GjsContextPrivate::eval()
    
    This annotation is wrong, an exception should not be pending when this
    method returns. Instead, it should be logged or reflected in the GError.

 gjs/context-private.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gjs/context-private.h b/gjs/context-private.h
index 8add9c2b..4f5adc8a 100644
--- a/gjs/context-private.h
+++ b/gjs/context-private.h
@@ -191,9 +191,9 @@ class GjsContextPrivate : public JS::JobQueue {
         return *(from_cx(cx)->m_atoms);
     }
 
-    GJS_JSAPI_RETURN_CONVENTION
-    bool eval(const char* script, ssize_t script_len, const char* filename,
-              int* exit_status_p, GError** error);
+    [[nodiscard]] bool eval(const char* script, ssize_t script_len,
+                            const char* filename, int* exit_status_p,
+                            GError** error);
     GJS_JSAPI_RETURN_CONVENTION
     bool eval_with_scope(JS::HandleObject scope_object, const char* script,
                          ssize_t script_len, const char* filename,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]