[gimp/wip/schumaml/export-as-dialog-title-issue-4021] app: use "Export Image As" for the "Export As..." dialog title




commit a44f80076d7a11788c922957099dd864da7c9c1b
Author: Michael Schumacher <schumaml gmx de>
Date:   Sat Feb 27 17:52:45 2021 +0100

    app: use "Export Image As" for the "Export As..." dialog title
    
    This addresses the inconsistency mentioned in merge request !415 for issue #4021. The API change is 
localized,
    there seem to be no uses of file_export_dialog_show() outside of file-commands.c.
    
    Export uses "Export Image", so I opted for "Export Image As" for consistency.

 app/actions/file-commands.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/app/actions/file-commands.c b/app/actions/file-commands.c
index e3f87637b5..e2a1f5339d 100644
--- a/app/actions/file-commands.c
+++ b/app/actions/file-commands.c
@@ -84,6 +84,7 @@ static GtkWidget * file_save_dialog_show        (Gimp         *gimp,
 static GtkWidget * file_export_dialog_show      (Gimp         *gimp,
                                                  GimpImage    *image,
                                                  GtkWidget    *parent,
+                                                 const gchar  *title,
                                                  GimpDisplay  *display);
 static void        file_save_dialog_response    (GtkWidget    *dialog,
                                                  gint          response_id,
@@ -304,7 +305,7 @@ file_save_cmd_callback (GimpAction *action,
       break;
 
     case GIMP_SAVE_MODE_EXPORT_AS:
-      file_export_dialog_show (gimp, image, widget, display);
+      file_export_dialog_show (gimp, image, widget, _("Export Image As"), display);
       break;
 
     case GIMP_SAVE_MODE_EXPORT:
@@ -322,7 +323,7 @@ file_save_cmd_callback (GimpAction *action,
             if (! file)
               {
                 /* Behave as if Export As... was invoked */
-                file_export_dialog_show (gimp, image, widget, display);
+                file_export_dialog_show (gimp, image, widget, _("Export Image"), display);
                 break;
               }
 
@@ -688,7 +689,7 @@ file_save_dialog_response (GtkWidget *dialog,
 
       other = file_export_dialog_show (GIMP_FILE_DIALOG (file_dialog)->image->gimp,
                                        GIMP_FILE_DIALOG (file_dialog)->image,
-                                       GTK_WIDGET (parent), NULL);
+                                       GTK_WIDGET (parent), _("Export Image"), NULL);
 
       gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (other), folder);
       gtk_file_chooser_set_current_name (GTK_FILE_CHOOSER (other), basename);
@@ -702,6 +703,7 @@ static GtkWidget *
 file_export_dialog_show (Gimp        *gimp,
                          GimpImage   *image,
                          GtkWidget   *parent,
+                         const gchar *title,
                          GimpDisplay *display)
 {
   GtkWidget *dialog;
@@ -740,6 +742,8 @@ file_export_dialog_show (Gimp        *gimp,
       gimp_export_dialog_set_image (GIMP_EXPORT_DIALOG (dialog), image,
                                     GIMP_OBJECT (display));
 
+      gtk_window_set_title (GTK_WINDOW (dialog), title);
+
       gtk_window_present (GTK_WINDOW (dialog));
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]