[gnome-music/wip/jfelder/fix-remove-song-from-playlist: 2/2] grltrackerplaylists: Check for failure on song deletion
- From: Jean Felder <jfelder src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music/wip/jfelder/fix-remove-song-from-playlist: 2/2] grltrackerplaylists: Check for failure on song deletion
- Date: Wed, 24 Feb 2021 17:38:19 +0000 (UTC)
commit b1bccb98c4cc6d5cf4bcc016cb892fd09d820564
Author: Jean Felder <jfelder src gnome org>
Date: Wed Feb 24 18:37:48 2021 +0100
grltrackerplaylists: Check for failure on song deletion
gnomemusic/grilowrappers/grltrackerplaylists.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/gnomemusic/grilowrappers/grltrackerplaylists.py b/gnomemusic/grilowrappers/grltrackerplaylists.py
index dad120d8c..b7f186e6e 100644
--- a/gnomemusic/grilowrappers/grltrackerplaylists.py
+++ b/gnomemusic/grilowrappers/grltrackerplaylists.py
@@ -501,8 +501,13 @@ class Playlist(GObject.GObject):
:param CoreSong coresong: song to remove
"""
def update_cb(conn, res):
- # FIXME: Check for failure.
- conn.update_finish(res)
+ try:
+ conn.update_finish(res)
+ except GLib.Error as e:
+ self._log.warning(
+ "Unable to remove song from playlist {}: {}",
+ self.props.title, e.message)
+
self._notificationmanager.pop_loading()
def entry_retrieved_cb(source, op_id, media, remaining, error):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]