GNOME.org
 

[shotwell/ricotz/vala] References of [GtkChild] fields is handled by GtkBuilder, type must be unowned


commit 5bbbd3ec69cac79bb4377e2777108e7d5b02ad1c
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Mon Feb 22 13:30:49 2021 +0100

    References of [GtkChild] fields is handled by GtkBuilder, type must be unowned

 .../shotwell-publishing/PhotosPublishingPane.vala  | 20 ++++++-------
 src/PageMessagePane.vala                           |  4 +--
 src/Printing.vala                                  | 24 +++++++--------
 src/SlideshowPage.vala                             | 14 ++++-----
 src/dialogs/MultiTextEntryDialog.vala              |  2 +-
 src/dialogs/Preferences.vala                       | 34 +++++++++++-----------
 src/dialogs/SetBackground.vala                     |  4 +--
 src/dialogs/SetBackgroundSlideshow.vala            |  8 ++---
 src/dialogs/TextEntry.vala                         |  4 +--
 src/plugins/ManifestWidget.vala                    |  4 +--
 src/publishing/LoginWelcomePaneWidget.vala         |  4 +--
 src/publishing/ProgressPaneWidget.vala             |  2 +-
 src/publishing/StaticMessagePaneWidget.vala        |  2 +-
 src/searches/SavedSearchDialog.vala                |  8 ++---
 14 files changed, 67 insertions(+), 67 deletions(-)
---
diff --git a/plugins/shotwell-publishing/PhotosPublishingPane.vala 
b/plugins/shotwell-publishing/PhotosPublishingPane.vala
index d1b00d6a..fe2dfbdd 100644
--- a/plugins/shotwell-publishing/PhotosPublishingPane.vala
+++ b/plugins/shotwell-publishing/PhotosPublishingPane.vala
@@ -22,25 +22,25 @@ internal class PublishingOptionsPane : Gtk.Box, Spit.Publishing.DialogPane {
     };
 
     [GtkChild]
-    private Gtk.Button logout_button;
+    private unowned Gtk.Button logout_button;
     [GtkChild]
-    private Gtk.Button publish_button;
+    private unowned Gtk.Button publish_button;
     [GtkChild]
-    private Gtk.RadioButton existing_album_radio;
+    private unowned Gtk.RadioButton existing_album_radio;
     [GtkChild]
-    private Gtk.ComboBoxText existing_albums_combo;
+    private unowned Gtk.ComboBoxText existing_albums_combo;
     [GtkChild]
-    private Gtk.ComboBoxText size_combo;
+    private unowned Gtk.ComboBoxText size_combo;
     [GtkChild]
-    private Gtk.Label publish_to_label;
+    private unowned Gtk.Label publish_to_label;
     [GtkChild]
-    private Gtk.Label login_identity_label;
+    private unowned Gtk.Label login_identity_label;
     [GtkChild]
-    private Gtk.CheckButton strip_metadata_check;
+    private unowned Gtk.CheckButton strip_metadata_check;
     [GtkChild]
-    private Gtk.RadioButton new_album_radio;
+    private unowned Gtk.RadioButton new_album_radio;
     [GtkChild]
-    private Gtk.Entry new_album_entry;
+    private unowned Gtk.Entry new_album_entry;
 
     public signal void publish();
     public signal void logout();
diff --git a/src/PageMessagePane.vala b/src/PageMessagePane.vala
index a5c5eee6..e773dadd 100644
--- a/src/PageMessagePane.vala
+++ b/src/PageMessagePane.vala
@@ -7,10 +7,10 @@
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/message_pane.ui")]
 private class PageMessagePane : Gtk.Box {
     [GtkChild]
-    public Gtk.Label label;
+    public unowned Gtk.Label label;
 
     [GtkChild]
-    public Gtk.Image icon_image;
+    public unowned Gtk.Image icon_image;
 
     public PageMessagePane() {
         Object();
diff --git a/src/Printing.vala b/src/Printing.vala
index 5fd893e0..bef34760 100644
--- a/src/Printing.vala
+++ b/src/Printing.vala
@@ -271,29 +271,29 @@ public class CustomPrintTab : Gtk.Box {
     private const int CENTIMETERS_COMBO_CHOICE = 1;
 
     [GtkChild]
-    private Gtk.RadioButton standard_size_radio;
+    private unowned Gtk.RadioButton standard_size_radio;
     [GtkChild]
-    private Gtk.RadioButton custom_size_radio;
+    private unowned Gtk.RadioButton custom_size_radio;
     [GtkChild]
-    private Gtk.RadioButton image_per_page_radio;
+    private unowned Gtk.RadioButton image_per_page_radio;
     [GtkChild]
-    private Gtk.ComboBoxText image_per_page_combo;
+    private unowned Gtk.ComboBoxText image_per_page_combo;
     [GtkChild]
-    private Gtk.ComboBoxText standard_sizes_combo;
+    private unowned Gtk.ComboBoxText standard_sizes_combo;
     [GtkChild]
-    private Gtk.ComboBoxText units_combo;
+    private unowned Gtk.ComboBoxText units_combo;
     [GtkChild]
-    private Gtk.Entry custom_width_entry;
+    private unowned Gtk.Entry custom_width_entry;
     [GtkChild]
-    private Gtk.Entry custom_height_entry;
+    private unowned Gtk.Entry custom_height_entry;
     [GtkChild]
-    private Gtk.Entry ppi_entry;
+    private unowned Gtk.Entry ppi_entry;
     [GtkChild]
-    private Gtk.CheckButton aspect_ratio_check;
+    private unowned Gtk.CheckButton aspect_ratio_check;
     [GtkChild]
-    private Gtk.CheckButton title_print_check;
+    private unowned Gtk.CheckButton title_print_check;
     [GtkChild]
-    private Gtk.FontButton title_print_font;
+    private unowned Gtk.FontButton title_print_font;
 
     private Measurement local_content_width = Measurement(5.0, MeasurementUnit.INCHES);
     private Measurement local_content_height = Measurement(5.0, MeasurementUnit.INCHES);
diff --git a/src/SlideshowPage.vala b/src/SlideshowPage.vala
index 98102361..adfec7f9 100644
--- a/src/SlideshowPage.vala
+++ b/src/SlideshowPage.vala
@@ -26,19 +26,19 @@ class SlideshowPage : SinglePhotoPage {
     [GtkTemplate (ui = "/org/gnome/Shotwell/ui/slideshow_settings.ui")]
     private class SettingsDialog : Gtk.Dialog {
         [GtkChild]
-        Gtk.Adjustment delay_adjustment;
+        unowned Gtk.Adjustment delay_adjustment;
         [GtkChild]
-        Gtk.SpinButton delay_entry;
+        unowned Gtk.SpinButton delay_entry;
         [GtkChild]
-        Gtk.ComboBoxText transition_effect_selector;
+        unowned Gtk.ComboBoxText transition_effect_selector;
         [GtkChild]
-        Gtk.Scale transition_effect_hscale;
+        unowned Gtk.Scale transition_effect_hscale;
         [GtkChild]
-        Gtk.SpinButton transition_effect_entry;
+        unowned Gtk.SpinButton transition_effect_entry;
         [GtkChild]
-        Gtk.Adjustment transition_effect_adjustment;
+        unowned Gtk.Adjustment transition_effect_adjustment;
         [GtkChild]
-        Gtk.CheckButton show_title_button;
+        unowned Gtk.CheckButton show_title_button;
         
         public SettingsDialog() {
             Object (use_header_bar: Resources.use_header_bar());
diff --git a/src/dialogs/MultiTextEntryDialog.vala b/src/dialogs/MultiTextEntryDialog.vala
index 42e53186..ddbd59be 100644
--- a/src/dialogs/MultiTextEntryDialog.vala
+++ b/src/dialogs/MultiTextEntryDialog.vala
@@ -11,7 +11,7 @@ public class MultiTextEntryDialog : Gtk.Dialog {
 
     private unowned OnModifyValidateType on_modify_validate;
     [GtkChild]
-    private Gtk.TextView entry;
+    private unowned Gtk.TextView entry;
 
     public MultiTextEntryDialog() {
         Object (use_header_bar: Resources.use_header_bar());
diff --git a/src/dialogs/Preferences.vala b/src/dialogs/Preferences.vala
index 123a9e0d..c6d63868 100644
--- a/src/dialogs/Preferences.vala
+++ b/src/dialogs/Preferences.vala
@@ -19,49 +19,49 @@ public class PreferencesDialog : Gtk.Dialog {
     private static PreferencesDialog preferences_dialog;
 
     [GtkChild]
-    private Gtk.Switch switch_dark;
+    private unowned Gtk.Switch switch_dark;
 
     [GtkChild]
-    private Gtk.ComboBox photo_editor_combo;
+    private unowned Gtk.ComboBox photo_editor_combo;
     [GtkChild]
-    private Gtk.ComboBox raw_editor_combo;
+    private unowned Gtk.ComboBox raw_editor_combo;
     private SortedList<AppInfo> external_raw_apps;
     private SortedList<AppInfo> external_photo_apps;
     [GtkChild]
-    private Gtk.FileChooserButton library_dir_button;
+    private unowned Gtk.FileChooserButton library_dir_button;
     [GtkChild]
-    private Gtk.ComboBoxText dir_pattern_combo;
+    private unowned Gtk.ComboBoxText dir_pattern_combo;
     [GtkChild]
-    private Gtk.Entry dir_pattern_entry;
+    private unowned Gtk.Entry dir_pattern_entry;
     [GtkChild]
-    private Gtk.Label dir_pattern_example;
+    private unowned Gtk.Label dir_pattern_example;
     private bool allow_closing = false;
     private string? lib_dir = null;
     private Gee.ArrayList<PathFormat> path_formats = new Gee.ArrayList<PathFormat>();
     private GLib.DateTime example_date = new GLib.DateTime.local(2009, 3, 10, 18, 16, 11);
     [GtkChild]
-    private Gtk.CheckButton lowercase;
+    private unowned Gtk.CheckButton lowercase;
     private Plugins.ManifestWidgetMediator plugins_mediator = new Plugins.ManifestWidgetMediator();
     [GtkChild]
-    private Gtk.ComboBoxText default_raw_developer_combo;
+    private unowned Gtk.ComboBoxText default_raw_developer_combo;
 
     [GtkChild]
-    private Gtk.CheckButton autoimport;
+    private unowned Gtk.CheckButton autoimport;
     [GtkChild]
-    private Gtk.CheckButton write_metadata;
+    private unowned Gtk.CheckButton write_metadata;
     [GtkChild]
-    private Gtk.Label pattern_help;
+    private unowned Gtk.Label pattern_help;
     [GtkChild]
-    private Gtk.Notebook preferences_notebook;
+    private unowned Gtk.Notebook preferences_notebook;
 
     [GtkChild]
-    private Gtk.RadioButton transparent_checker_radio;
+    private unowned Gtk.RadioButton transparent_checker_radio;
     [GtkChild]
-    private Gtk.RadioButton transparent_solid_radio;
+    private unowned Gtk.RadioButton transparent_solid_radio;
     [GtkChild]
-    private Gtk.ColorButton transparent_solid_color;
+    private unowned Gtk.ColorButton transparent_solid_color;
     [GtkChild]
-    private Gtk.RadioButton transparent_none_radio;
+    private unowned Gtk.RadioButton transparent_none_radio;
 
     private PreferencesDialog() {
         Object (use_header_bar: Resources.use_header_bar());
diff --git a/src/dialogs/SetBackground.vala b/src/dialogs/SetBackground.vala
index d9a77c43..ec565022 100644
--- a/src/dialogs/SetBackground.vala
+++ b/src/dialogs/SetBackground.vala
@@ -8,9 +8,9 @@
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/set_background_dialog.ui")]
 public class SetBackgroundPhotoDialog : Gtk.Dialog {
     [GtkChild]
-    private Gtk.CheckButton desktop_background_checkbox;
+    private unowned Gtk.CheckButton desktop_background_checkbox;
     [GtkChild]
-    private Gtk.CheckButton screensaver_checkbox;
+    private unowned Gtk.CheckButton screensaver_checkbox;
 
     public SetBackgroundPhotoDialog() {
         Object(use_header_bar: Resources.use_header_bar());
diff --git a/src/dialogs/SetBackgroundSlideshow.vala b/src/dialogs/SetBackgroundSlideshow.vala
index 914af76a..479b0c7a 100644
--- a/src/dialogs/SetBackgroundSlideshow.vala
+++ b/src/dialogs/SetBackgroundSlideshow.vala
@@ -8,13 +8,13 @@
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/set_background_slideshow_dialog.ui")]
 public class SetBackgroundSlideshowDialog : Gtk.Dialog {
     [GtkChild]
-    private Gtk.CheckButton desktop_background_checkbox;
+    private unowned Gtk.CheckButton desktop_background_checkbox;
     [GtkChild]
-    private Gtk.CheckButton screensaver_checkbox;
+    private unowned Gtk.CheckButton screensaver_checkbox;
     [GtkChild]
-    private Gtk.Scale delay_scale;
+    private unowned Gtk.Scale delay_scale;
     [GtkChild]
-    private Gtk.Label delay_value_label;
+    private unowned Gtk.Label delay_value_label;
 
     private int delay_value = 0;
 
diff --git a/src/dialogs/TextEntry.vala b/src/dialogs/TextEntry.vala
index d82fdbd8..a2e4653a 100644
--- a/src/dialogs/TextEntry.vala
+++ b/src/dialogs/TextEntry.vala
@@ -12,10 +12,10 @@ public class TextEntryDialog : Gtk.Dialog {
     private unowned OnModifyValidateType on_modify_validate;
 
     [GtkChild]
-    private Gtk.Entry entry;
+    private unowned Gtk.Entry entry;
 
     [GtkChild]
-    private Gtk.Label label;
+    private unowned Gtk.Label label;
 
     public TextEntryDialog() {
         Object (use_header_bar: Resources.use_header_bar());
diff --git a/src/plugins/ManifestWidget.vala b/src/plugins/ManifestWidget.vala
index e6e638c1..298d6117 100644
--- a/src/plugins/ManifestWidget.vala
+++ b/src/plugins/ManifestWidget.vala
@@ -10,10 +10,10 @@ namespace Plugins {
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/manifest_widget.ui")]
 public class ManifestWidgetMediator : Gtk.Box {
     [GtkChild]
-    private Gtk.Button about_button;
+    private unowned Gtk.Button about_button;
     
     [GtkChild]
-    private Gtk.ScrolledWindow list_bin;
+    private unowned Gtk.ScrolledWindow list_bin;
     
     private ManifestListView list = new ManifestListView();
     
diff --git a/src/publishing/LoginWelcomePaneWidget.vala b/src/publishing/LoginWelcomePaneWidget.vala
index ba480525..3e9847b4 100644
--- a/src/publishing/LoginWelcomePaneWidget.vala
+++ b/src/publishing/LoginWelcomePaneWidget.vala
@@ -10,9 +10,9 @@ namespace PublishingUI {
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/login_welcome_pane_widget.ui")]
 public class LoginWelcomePane : Spit.Publishing.DialogPane, Gtk.Box {
     [GtkChild]
-    private Gtk.Button login_button;
+    private unowned Gtk.Button login_button;
     [GtkChild]
-    private Gtk.Label not_logged_in_label;
+    private unowned Gtk.Label not_logged_in_label;
 
     public Gtk.Widget get_widget() {
         return this;
diff --git a/src/publishing/ProgressPaneWidget.vala b/src/publishing/ProgressPaneWidget.vala
index bf8af1da..0c89d772 100644
--- a/src/publishing/ProgressPaneWidget.vala
+++ b/src/publishing/ProgressPaneWidget.vala
@@ -10,7 +10,7 @@ namespace PublishingUI {
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/progress_pane_widget.ui")]
 public class ProgressPane : Spit.Publishing.DialogPane, Gtk.Box {
     [GtkChild]
-    private Gtk.ProgressBar progress_bar;
+    private unowned Gtk.ProgressBar progress_bar;
 
     public Gtk.Widget get_widget() {
         return this;
diff --git a/src/publishing/StaticMessagePaneWidget.vala b/src/publishing/StaticMessagePaneWidget.vala
index 1ed6b0a7..6d51e972 100644
--- a/src/publishing/StaticMessagePaneWidget.vala
+++ b/src/publishing/StaticMessagePaneWidget.vala
@@ -10,7 +10,7 @@ namespace PublishingUI {
 [GtkTemplate (ui = "/org/gnome/Shotwell/ui/static_message_pane_widget.ui")]
 public class StaticMessagePane : Spit.Publishing.DialogPane, Gtk.Box {
     [GtkChild]
-    private Gtk.Label static_msg_label;
+    private unowned Gtk.Label static_msg_label;
 
     public Gtk.Widget get_widget() {
         return this;
diff --git a/src/searches/SavedSearchDialog.vala b/src/searches/SavedSearchDialog.vala
index 012f3370..0ba5426b 100644
--- a/src/searches/SavedSearchDialog.vala
+++ b/src/searches/SavedSearchDialog.vala
@@ -643,13 +643,13 @@ public class SavedSearchDialog : Gtk.Dialog {
     }
     
     [GtkChild]
-    private Gtk.Button add_criteria;
+    private unowned Gtk.Button add_criteria;
     [GtkChild]
-    private Gtk.ComboBoxText operator;
+    private unowned Gtk.ComboBoxText operator;
     [GtkChild]
-    private Gtk.Entry search_title;
+    private unowned Gtk.Entry search_title;
     [GtkChild]
-    private Gtk.ListBox row_listbox;
+    private unowned Gtk.ListBox row_listbox;
 
     private Gee.ArrayList<SearchRowContainer> row_list = new Gee.ArrayList<SearchRowContainer>();
     private bool edit_mode = false;
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]