[gtk/wip/chergert/glproto: 393/493] prefer pointer math




commit c2ba996966023eb53dfe4e963f14f6bce0c2ff98
Author: Christian Hergert <chergert redhat com>
Date:   Thu Feb 4 14:01:59 2021 -0800

    prefer pointer math

 gsk/next/gskglcommandqueue.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/gsk/next/gskglcommandqueue.c b/gsk/next/gskglcommandqueue.c
index 2abdd0df64..1f697912ec 100644
--- a/gsk/next/gskglcommandqueue.c
+++ b/gsk/next/gskglcommandqueue.c
@@ -889,11 +889,10 @@ gsk_gl_command_queue_execute (GskGLCommandQueue    *self,
 
           if G_UNLIKELY (batch->draw.bind_count > 0)
             {
+              const GskGLCommandBind *bind = &g_array_index (self->batch_binds, GskGLCommandBind, 
batch->draw.bind_offset);
+
               for (guint i = 0; i < batch->draw.bind_count; i++)
                 {
-                  guint index = batch->draw.bind_offset + i;
-                  GskGLCommandBind *bind = &g_array_index (self->batch_binds, GskGLCommandBind, index);
-
                   if (active != bind->texture)
                     {
                       active = bind->texture;
@@ -901,20 +900,19 @@ gsk_gl_command_queue_execute (GskGLCommandQueue    *self,
                     }
 
                   glBindTexture (GL_TEXTURE_2D, bind->id);
+                  bind++;
                 }
             }
 
           if (batch->draw.uniform_count > 0)
             {
+              const GskGLCommandUniform *u = &g_array_index (self->batch_uniforms, GskGLCommandUniform, 
batch->draw.uniform_offset);
+
               for (guint i = 0; i < batch->draw.uniform_count; i++)
                 {
-                  guint index = batch->draw.uniform_offset + i;
-                  GskGLCommandUniform *u = &g_array_index (self->batch_uniforms, GskGLCommandUniform, index);
-
-                  g_assert (index < self->batch_uniforms->len);
-
                   apply_uniform (gsk_gl_uniform_state_get_uniform_data (self->uniforms, u->info.offset),
                                  u->info, u->location);
+                  u++;
                 }
 
               n_uniforms += batch->draw.uniform_count;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]