[orca] Be less strict about which input events we treat as Tab navigation



commit bd393d116e2b4a2c9307f95d20d6bc9b2f084c49
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Feb 18 18:51:04 2021 +0100

    Be less strict about which input events we treat as Tab navigation
    
    At least some users have Tab input events for which there is a modifier
    we don't recognize. As a result, we can fail to recognize Tab/Shift+Tab
    navigation which can impact what we do or do not present. Therefore,
    just filter out things we don't wish to treat as Tab navigation, such
    as Alt, Ctrl, and the Orca modifier.

 src/orca/script_utilities.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index d12c96078..2f01f8b3d 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -5334,7 +5334,12 @@ class Utilities:
         if keyString not in ["Tab", "ISO_Left_Tab"]:
             return False
 
-        return not mods or mods & keybindings.SHIFT_MODIFIER_MASK
+        if mods & keybindings.CTRL_MODIFIER_MASK \
+           or mods & keybindings.ALT_MODIFIER_MASK \
+           or mods & keybindings.ORCA_MODIFIER_MASK:
+            return False
+
+        return True
 
     def lastInputEventWasMouseButton(self):
         return isinstance(orca_state.lastInputEvent, input_event.MouseButtonEvent)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]