[epiphany/wip/exalm/shortcuts] window-commands: Hide webapp shortcuts instead of destroying




commit 16aa45ebec0e53d556cb06b8edbd1467580d8a8b
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Thu Feb 18 13:53:49 2021 +0500

    window-commands: Hide webapp shortcuts instead of destroying
    
    Avoid a use-after-free.
    
    Fixes https://gitlab.gnome.org/GNOME/epiphany/-/issues/1452

 src/window-commands.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/window-commands.c b/src/window-commands.c
index 809100771..ac6da6309 100644
--- a/src/window-commands.c
+++ b/src/window-commands.c
@@ -917,7 +917,7 @@ window_cmd_show_shortcuts (GSimpleAction *action,
     shortcuts_window = GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-dialog"));
 
     if (ephy_is_running_inside_flatpak ())
-      gtk_widget_destroy (GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-web-apps-group")));
+      gtk_widget_hide (GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-web-apps-group")));
 
     if (gtk_widget_get_default_direction () == GTK_TEXT_DIR_RTL) {
       GtkShortcutsShortcut *shortcut;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]