[gnome-shell] gdm: Override any other lower-priority service message on error

[Marge Bot <marge-bot src gnome org>]

commit b74900b3a3dd7cd6484255e2ef209e3a65507294
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date:   Tue Feb 16 03:56:09 2021 +0100

    gdm: Override any other lower-priority service message on error
    
    When we got an error, all the other HINT or INFO messages are not useful
    anymore and delaying to show them is just a waste of time and may be
    even wrong in scenarios with fast authentication devices.
    
    An example are the fingerprint devices, where the user may touch the
    sensor repeatedly while we may still show the "touch the sensor" hint
    instead of notifying of possible errors.
    
    So, in case we got an error override all the other errors coming from
    the same service with lower priority.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1683>

 js/gdm/util.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/js/gdm/util.js b/js/gdm/util.js
index f1c3c91497..1ee84acde2 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -603,7 +603,8 @@ var ShellUserVerifier = class {
         if (!this.serviceIsForeground(serviceName) && !isFingerprint)
             return;
 
-        this._queueMessage(serviceName, problem, MessageType.ERROR);
+        this._queuePriorityMessage(serviceName, problem, MessageType.ERROR);
+
         if (isFingerprint) {
             // pam_fprintd allows the user to retry multiple (maybe even infinite!
             // times before failing the authentication conversation.