[gnome-contacts/fix-unowned-warnings: 1/2] Declare all [GtkChild] members as unowned




commit 53bee039a27b51c283ee1b3022f047faf287ba7f
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Sat Feb 13 11:07:41 2021 +0100

    Declare all [GtkChild] members as unowned
    
    These members are already owned by their respective parent widgets, so
    you shouldn't keep an extra reference on them. Vala also warns about
    this in the latest version, so this fixes quite a few warnings on
    the latest `valac`.

 src/contacts-avatar-selector.vala        |  4 ++--
 src/contacts-contact-pane.vala           |  8 +++----
 src/contacts-crop-cheese-dialog.vala     |  4 ++--
 src/contacts-in-app-notification.vala    |  4 ++--
 src/contacts-link-suggestion-grid.vala   |  8 +++----
 src/contacts-linked-personas-dialog.vala |  2 +-
 src/contacts-list-pane.vala              | 10 ++++-----
 src/contacts-main-window.vala            | 38 ++++++++++++++++----------------
 src/contacts-setup-window.vala           |  4 ++--
 9 files changed, 41 insertions(+), 41 deletions(-)
---
diff --git a/src/contacts-avatar-selector.vala b/src/contacts-avatar-selector.vala
index 1684b340..21790696 100644
--- a/src/contacts-avatar-selector.vala
+++ b/src/contacts-avatar-selector.vala
@@ -71,11 +71,11 @@ public class Contacts.AvatarSelector : Gtk.Window {
   private Individual individual;
 
   [GtkChild]
-  private Gtk.FlowBox thumbnail_grid;
+  private unowned Gtk.FlowBox thumbnail_grid;
 
 #if HAVE_CHEESE
   [GtkChild]
-  private Gtk.Button cheese_button;
+  private unowned Gtk.Button cheese_button;
   private int num_cameras;
   private Cheese.CameraDeviceMonitor camera_monitor;
 #endif
diff --git a/src/contacts-contact-pane.vala b/src/contacts-contact-pane.vala
index 0796a11f..bb52992e 100644
--- a/src/contacts-contact-pane.vala
+++ b/src/contacts-contact-pane.vala
@@ -34,23 +34,23 @@ public class Contacts.ContactPane : Gtk.Bin {
   public Individual? individual { get; set; default = null; }
 
   [GtkChild]
-  private Gtk.Stack stack;
+  private unowned Gtk.Stack stack;
 
   [GtkChild]
-  private Hdy.StatusPage none_selected_page;
+  private unowned Hdy.StatusPage none_selected_page;
 
   [GtkChild]
   private unowned Gtk.ScrolledWindow contact_sheet_view;
 
   [GtkChild]
-  private Gtk.Container contact_sheet_page;
+  private unowned Gtk.Container contact_sheet_page;
   private ContactSheet? sheet = null;
 
   [GtkChild]
   private unowned Gtk.ScrolledWindow contact_editor_view;
 
   [GtkChild]
-  private Gtk.Box contact_editor_page;
+  private unowned Gtk.Box contact_editor_page;
   private ContactEditor? editor = null;
 
   public bool on_edit_mode = false;
diff --git a/src/contacts-crop-cheese-dialog.vala b/src/contacts-crop-cheese-dialog.vala
index e0c94398..1904d8a4 100644
--- a/src/contacts-crop-cheese-dialog.vala
+++ b/src/contacts-crop-cheese-dialog.vala
@@ -18,9 +18,9 @@
 [GtkTemplate (ui = "/org/gnome/Contacts/ui/contacts-crop-cheese-dialog.ui")]
 public class Contacts.CropCheeseDialog : Gtk.Window {
   [GtkChild]
-  private Gtk.Stack stack;
+  private unowned Gtk.Stack stack;
   [GtkChild]
-  private Gtk.Button take_another_button;
+  private unowned Gtk.Button take_another_button;
 
   private Cc.CropArea crop_area;
   private const string STACK_NAME_CROP = "crop";
diff --git a/src/contacts-in-app-notification.vala b/src/contacts-in-app-notification.vala
index 25857e22..63256655 100644
--- a/src/contacts-in-app-notification.vala
+++ b/src/contacts-in-app-notification.vala
@@ -21,10 +21,10 @@ public class Contacts.InAppNotification : Gtk.Revealer {
   private const uint DEFAULT_KEEPALIVE = 5;
 
   [GtkChild]
-  private Gtk.Grid grid;
+  private unowned Gtk.Grid grid;
 
   [GtkChild]
-  private Gtk.Label label;
+  private unowned Gtk.Label label;
   public Gtk.Label message_label {
     get { return this.label; }
   }
diff --git a/src/contacts-link-suggestion-grid.vala b/src/contacts-link-suggestion-grid.vala
index cad38dc7..967ed68f 100644
--- a/src/contacts-link-suggestion-grid.vala
+++ b/src/contacts-link-suggestion-grid.vala
@@ -27,13 +27,13 @@ public class Contacts.LinkSuggestionGrid : Gtk.Grid {
   private const int AVATAR_SIZE = 54;
 
   [GtkChild]
-  private Gtk.Label description_label;
+  private unowned Gtk.Label description_label;
   [GtkChild]
-  private Gtk.Label extra_info_label;
+  private unowned Gtk.Label extra_info_label;
   [GtkChild]
-  private Gtk.Button accept_button;
+  private unowned Gtk.Button accept_button;
   [GtkChild]
-  private Gtk.Button reject_button;
+  private unowned Gtk.Button reject_button;
 
   public signal void suggestion_accepted ();
   public signal void suggestion_rejected ();
diff --git a/src/contacts-linked-personas-dialog.vala b/src/contacts-linked-personas-dialog.vala
index 9c26b4db..26f3ca36 100644
--- a/src/contacts-linked-personas-dialog.vala
+++ b/src/contacts-linked-personas-dialog.vala
@@ -22,7 +22,7 @@ public class Contacts.LinkedPersonasDialog : Gtk.Dialog {
   private const int AVATAR_SIZE = 54;
 
   [GtkChild]
-  private Gtk.ListBox linked_accounts_view;
+  private unowned Gtk.ListBox linked_accounts_view;
 
   private Individual individual;
 
diff --git a/src/contacts-list-pane.vala b/src/contacts-list-pane.vala
index d16a132a..1cf62d59 100644
--- a/src/contacts-list-pane.vala
+++ b/src/contacts-list-pane.vala
@@ -22,21 +22,21 @@ public class Contacts.ListPane : Gtk.Frame {
   private Store store;
 
   [GtkChild]
-  private Gtk.ScrolledWindow contacts_list_container;
+  private unowned Gtk.ScrolledWindow contacts_list_container;
   private ContactList contacts_list;
 
   [GtkChild]
-  public Gtk.SearchEntry filter_entry;
+  public unowned Gtk.SearchEntry filter_entry;
   private SimpleQuery filter_query;
 
   [GtkChild]
-  private Gtk.Button link_button;
+  private unowned Gtk.Button link_button;
 
   [GtkChild]
-  private Gtk.Button delete_button;
+  private unowned Gtk.Button delete_button;
 
   [GtkChild]
-  private Gtk.ActionBar actions_bar;
+  private unowned Gtk.ActionBar actions_bar;
 
   public UiState state { get; set; }
 
diff --git a/src/contacts-main-window.vala b/src/contacts-main-window.vala
index d79c39fd..94c793f7 100644
--- a/src/contacts-main-window.vala
+++ b/src/contacts-main-window.vala
@@ -28,44 +28,44 @@ public class Contacts.MainWindow : Hdy.ApplicationWindow {
   };
 
   [GtkChild]
-  private Hdy.Leaflet header;
+  private unowned Hdy.Leaflet header;
   [GtkChild]
-  private Hdy.Leaflet content_box;
+  private unowned Hdy.Leaflet content_box;
   [GtkChild]
-  private Gtk.Revealer back_revealer;
+  private unowned Gtk.Revealer back_revealer;
   [GtkChild]
-  private Gtk.Stack list_pane_stack;
+  private unowned Gtk.Stack list_pane_stack;
   [GtkChild]
-  private Gtk.Container contact_pane_container;
+  private unowned Gtk.Container contact_pane_container;
   [GtkChild]
-  private Hdy.HeaderBar left_header;
+  private unowned Hdy.HeaderBar left_header;
   [GtkChild]
-  private Gtk.Separator header_separator;
+  private unowned Gtk.Separator header_separator;
   [GtkChild]
-  private Hdy.HeaderBar right_header;
+  private unowned Hdy.HeaderBar right_header;
   [GtkChild]
-  private Gtk.Overlay notification_overlay;
+  private unowned Gtk.Overlay notification_overlay;
   [GtkChild]
-  private Gtk.Button select_cancel_button;
+  private unowned Gtk.Button select_cancel_button;
   [GtkChild]
-  private Gtk.MenuButton hamburger_menu_button;
+  private unowned Gtk.MenuButton hamburger_menu_button;
   [GtkChild]
-  private Gtk.ModelButton sort_on_firstname_button;
+  private unowned Gtk.ModelButton sort_on_firstname_button;
   [GtkChild]
-  private Gtk.ModelButton sort_on_surname_button;
+  private unowned Gtk.ModelButton sort_on_surname_button;
   [GtkChild]
-  private Gtk.MenuButton contact_menu_button;
+  private unowned Gtk.MenuButton contact_menu_button;
   [GtkChild]
-  private Gtk.ToggleButton favorite_button;
+  private unowned Gtk.ToggleButton favorite_button;
   private bool ignore_favorite_button_toggled;
   [GtkChild]
-  private Gtk.Button unlink_button;
+  private unowned Gtk.Button unlink_button;
   [GtkChild]
-  private Gtk.Button add_button;
+  private unowned Gtk.Button add_button;
   [GtkChild]
-  private Gtk.Button cancel_button;
+  private unowned Gtk.Button cancel_button;
   [GtkChild]
-  private Gtk.Button done_button;
+  private unowned Gtk.Button done_button;
 
   // The 2 panes the window consists of
   private ListPane list_pane;
diff --git a/src/contacts-setup-window.vala b/src/contacts-setup-window.vala
index 19a3db01..0461fc64 100644
--- a/src/contacts-setup-window.vala
+++ b/src/contacts-setup-window.vala
@@ -20,10 +20,10 @@ using Folks;
 [GtkTemplate (ui = "/org/gnome/Contacts/ui/contacts-setup-window.ui")]
 public class Contacts.SetupWindow : Hdy.ApplicationWindow {
   [GtkChild]
-  private Hdy.Clamp content;
+  private unowned Hdy.Clamp content;
 
   [GtkChild]
-  private Gtk.Button setup_done_button;
+  private unowned Gtk.Button setup_done_button;
 
   private AccountsList setup_accounts_list;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]