[gnome-shell/wip/rstrode/rhel-7.9: 68/86] keyboard: defer position-changed till we have a rect
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/rstrode/rhel-7.9: 68/86] keyboard: defer position-changed till we have a rect
- Date: Fri, 12 Feb 2021 19:04:07 +0000 (UTC)
commit e6d4594a1a73924164a5164eda7cfc7b581596ba
Author: Carlos Garnacho <carlosg gnome org>
Date: Sat Jul 14 00:14:07 2018 +0200
keyboard: defer position-changed till we have a rect
Emitting it that soon results in JS warnings, as we don't have
everything in place yet. The position-changed signal will be
emitted from other locations as soon as we have it.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/464
Closes: #464
js/ui/keyboard.js | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 26e9a8de89..5d0cc52ab8 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -530,9 +530,7 @@ var FocusTracker = new Lang.Class({
this._currentWindow = window;
if (window) {
this._currentWindowPositionId = this._currentWindow.connect('position-changed', () => {
- if (global.display.get_grab_op() == Meta.GrabOp.NONE)
- this.emit('position-changed');
- else
+ if (global.display.get_grab_op() != Meta.GrabOp.NONE)
this.emit('reset');
});
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]