[gnome-shell] screenshot: Remove shooter from sender in finally block
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] screenshot: Remove shooter from sender in finally block
- Date: Thu, 11 Feb 2021 18:56:35 +0000 (UTC)
commit 3510b88bdcdada5b4da6efbd6c8ccea2adcbb514
Author: Jonas Dreßler <verdre v0yd nl>
Date: Tue Feb 9 17:09:05 2021 +0100
screenshot: Remove shooter from sender in finally block
We do this in both the try{} and the catch{} block, so we might as well
put it into a finally{} block.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1658>
js/ui/screenshot.js | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/screenshot.js b/js/ui/screenshot.js
index 59a6c46aff..583f8b7c54 100644
--- a/js/ui/screenshot.js
+++ b/js/ui/screenshot.js
@@ -200,10 +200,10 @@ var ScreenshotService = class {
screenshot.screenshot_area(x, y, width, height, stream),
]);
this._onScreenshotComplete(stream, file, invocation);
- this._removeShooterForSender(invocation.get_sender());
} catch (e) {
- this._removeShooterForSender(invocation.get_sender());
invocation.return_value(new GLib.Variant('(bs)', [false, '']));
+ } finally {
+ this._removeShooterForSender(invocation.get_sender());
}
}
@@ -223,10 +223,10 @@ var ScreenshotService = class {
screenshot.screenshot_window(includeFrame, includeCursor, stream),
]);
this._onScreenshotComplete(stream, file, invocation);
- this._removeShooterForSender(invocation.get_sender());
} catch (e) {
- this._removeShooterForSender(invocation.get_sender());
invocation.return_value(new GLib.Variant('(bs)', [false, '']));
+ } finally {
+ this._removeShooterForSender(invocation.get_sender());
}
}
@@ -246,10 +246,10 @@ var ScreenshotService = class {
screenshot.screenshot(includeCursor, stream),
]);
this._onScreenshotComplete(stream, file, invocation);
- this._removeShooterForSender(invocation.get_sender());
} catch (e) {
- this._removeShooterForSender(invocation.get_sender());
invocation.return_value(new GLib.Variant('(bs)', [false, '']));
+ } finally {
+ this._removeShooterForSender(invocation.get_sender());
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]