GNOME.org
 

[folks/wip/carlosg/tracker3] tracker: Drop Tracker code


commit e9215d3393251ee8ba7938ea844f70d10afdef35
Author: Carlos Garnacho <carlosg gnome org>
Date:   Mon Jan 25 00:46:37 2021 +0100

    tracker: Drop Tracker code
    
    The story of saved contacts in Tracker is a convoluted one,
    and this code is mostly an artifact. 65 Million years ago, when
    Nokia dominated the world, Maemo/meego relied on Tracker and had
    specialized contact apps that used it as a storage.
    
    After Elop hit the Earth, saved contacts barely survived the
    event, mostly feeding off a small Evolution plugin. But that
    was not meant to last long, the evolution plugin went extinct,
    taking all traces of saved contacts with it. Just the ontology
    remained, a hollow shell that yes, could be able to hold a
    contact, would they still exist.
    
    Modern times arrived, and with them the interest on archeology,
    thus this fossilized piece of code is found and taken to the
    museum where it belongs.
    
    Should Tracker-using contacts ever exist again, the way to
    communicate with them would be radically different, let this code
    be a testimony of how it won't be done.
    
    Fixes: https://gitlab.gnome.org/GNOME/folks/-/issues/126

 CONTRIBUTING.md                                    |    2 +-
 backends/meson.build                               |    4 -
 backends/tracker/lib/folks-tracker.deps.in         |    4 -
 backends/tracker/lib/folks-tracker.map             |    7 -
 backends/tracker/lib/meson.build                   |   96 -
 backends/tracker/lib/trf-persona-store.vala        | 2789 --------------------
 backends/tracker/lib/trf-persona.vala              | 1516 -----------
 backends/tracker/lib/trf-util.vala                 |  164 --
 backends/tracker/meson.build                       |   37 -
 backends/tracker/tr-backend-factory.vala           |   46 -
 backends/tracker/tr-backend.vala                   |  240 --
 docs/meson.build                                   |    9 -
 docs/wiki/debugging.valadoc                        |    1 -
 folks/build-conf.vapi                              |    6 -
 meson.build                                        |   24 -
 meson_options.txt                                  |    1 -
 po/POTFILES.in                                     |    1 -
 po/POTFILES.skip                                   |    1 -
 tests/lib/meson.build                              |    3 -
 tests/lib/test-case.vala                           |    3 +-
 tests/lib/tracker/backend.vala                     |  558 ----
 tests/lib/tracker/meson.build                      |   22 -
 tests/lib/tracker/test-case.vala                   |  158 --
 tests/meson.build                                  |    3 -
 tests/template.test.in                             |    2 +-
 tests/tracker/add-contact.vala                     |  130 -
 tests/tracker/add-persona.vala                     |  521 ----
 tests/tracker/additional-names-updates.vala        |  149 --
 tests/tracker/avatar-details-interface.vala        |  134 -
 tests/tracker/avatar-updates.vala                  |  168 --
 tests/tracker/birthday-details-interface.vala      |  137 -
 tests/tracker/birthday-updates.vala                |  168 --
 tests/tracker/default-contact.vala                 |  131 -
 tests/tracker/duplicated-emails.vala               |  206 --
 tests/tracker/duplicated-phones.vala               |  206 --
 tests/tracker/email-details-interface.vala         |  137 -
 tests/tracker/emails-updates.vala                  |  194 --
 tests/tracker/family-name-updates.vala             |  146 -
 tests/tracker/favourite-details-interface.vala     |  153 --
 tests/tracker/favourite-updates.vala               |  168 --
 tests/tracker/fullname-updates.vala                |  139 -
 tests/tracker/gender-details-interface.vala        |  130 -
 tests/tracker/given-name-updates.vala              |  147 --
 tests/tracker/im-details-interface.vala            |  155 --
 tests/tracker/imaddresses-updates.vala             |  193 --
 tests/tracker/individual-retrieval.vala            |  125 -
 tests/tracker/link-personas-via-local-ids.vala     |  283 --
 tests/tracker/link-personas.vala                   |  296 ---
 tests/tracker/match-all.vala                       |  232 --
 tests/tracker/match-email-addresses.vala           |  211 --
 tests/tracker/match-im-addresses.vala              |  211 --
 tests/tracker/match-known-emails.vala              |  219 --
 tests/tracker/match-name.vala                      |  249 --
 tests/tracker/match-phone-number.vala              |  213 --
 tests/tracker/meson.build                          |   99 -
 tests/tracker/name-details-interface.vala          |  163 --
 tests/tracker/nickname-updates.vala                |  145 -
 tests/tracker/note-details-interface.vala          |  153 --
 tests/tracker/phone-details-interface.vala         |  136 -
 tests/tracker/phones-updates.vala                  |  183 --
 .../tracker/postal-address-details-interface.vala  |  180 --
 tests/tracker/prefix-name-updates.vala             |  145 -
 tests/tracker/remove-contact.vala                  |  133 -
 tests/tracker/remove-persona.vala                  |  207 --
 tests/tracker/role-details-interface.vala          |  144 -
 tests/tracker/set-avatar.vala                      |  140 -
 tests/tracker/set-birthday.vala                    |  143 -
 tests/tracker/set-duplicate-email.vala             |  217 --
 tests/tracker/set-emails.vala                      |  152 --
 tests/tracker/set-favourite.vala                   |  173 --
 tests/tracker/set-full-name.vala                   |  134 -
 tests/tracker/set-gender.vala                      |  131 -
 tests/tracker/set-im-addresses.vala                |  168 --
 tests/tracker/set-nickname.vala                    |  154 --
 tests/tracker/set-notes.vala                       |  144 -
 tests/tracker/set-null-avatar.vala                 |  127 -
 tests/tracker/set-phones.vala                      |  153 --
 tests/tracker/set-postal-addresses.vala            |  164 --
 tests/tracker/set-roles.vala                       |  148 --
 tests/tracker/set-structured-name.vala             |  145 -
 tests/tracker/set-urls.vala                        |  170 --
 tests/tracker/suffix-name-updates.vala             |  147 --
 tests/tracker/url-details-interface.vala           |  136 -
 tests/tracker/website-updates.vala                 |  162 --
 84 files changed, 3 insertions(+), 15841 deletions(-)
---
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index fa75eacb..4ca978f5 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -183,7 +183,7 @@ but then running it against an older version with a different API. EDS exposes
 its API version in its D-Bus interface, so if the wrong version of EDS is
 running, folks can’t find it on the bus, which cripples folks’ EDS backend.
 The same principle applies to other D-Bus services which folks relies on, such
-as Telepathy and Tracker.
+as Telepathy.
 
 There are two ways to fix this:
  • If you wish to use your desktop’s session bus, re-compile folks against the
diff --git a/backends/meson.build b/backends/meson.build
index f975ed15..f3557257 100644
--- a/backends/meson.build
+++ b/backends/meson.build
@@ -27,10 +27,6 @@ if telepathy_backend_enabled
   subdir('telepathy')
 endif
 
-if tracker_backend_enabled
-  subdir('tracker')
-endif
-
 if eds_backend_enabled
   subdir('eds')
 endif
diff --git a/docs/meson.build b/docs/meson.build
index 4d5ae34b..7ace84bd 100644
--- a/docs/meson.build
+++ b/docs/meson.build
@@ -52,15 +52,6 @@ if telepathy_backend_enabled
   }
 endif
 
-if tracker_backend_enabled
-  valadoc_targets += {
-    'name': 'folks-tracker',
-    'source_files': tracker_backendlib_sources,
-    'library': tracker_backendlib,
-    'dependencies': tracker_backendlib_doc_deps,
-  }
-endif
-
 # First, the devhelp modules
 subdir('devhelp')
 
diff --git a/docs/wiki/debugging.valadoc b/docs/wiki/debugging.valadoc
index c7bd6b9b..5100932f 100644
--- a/docs/wiki/debugging.valadoc
+++ b/docs/wiki/debugging.valadoc
@@ -10,7 +10,6 @@ Available values for folks for the ''G_MESSAGES_DEBUG'' environment variable are
  * ''eds'' (for the evolution-data-server backend)
  * ''key-file'' (for the key file backend)
  * ''telepathy'' (for the Telepathy backend)
- * ''tracker'' (for the Tracker backend)
 
 Multiple values can be specified using commas, e.g.: ''G_MESSAGES_DEBUG=folks,eds,key-file''.
 
diff --git a/folks/build-conf.vapi b/folks/build-conf.vapi
index 6567436f..36853a2a 100644
--- a/folks/build-conf.vapi
+++ b/folks/build-conf.vapi
@@ -63,12 +63,6 @@ public class Folks.BuildConf
   [CCode (cname = "HAVE_TELEPATHY")]
   public static bool HAVE_TELEPATHY;
 
-  [CCode (cname = "HAVE_TRACKER")]
-  public static bool HAVE_TRACKER;
-
-  [CCode (cname = "TRACKER_SPARQL_MAJOR")]
-  public const string TRACKER_SPARQL_MAJOR;
-
   [CCode (cname = "ABS_TOP_BUILDDIR")]
   public const string ABS_TOP_BUILDDIR;
 
diff --git a/meson.build b/meson.build
index 123edb5c..5dc066ee 100644
--- a/meson.build
+++ b/meson.build
@@ -30,7 +30,6 @@ folks_lib_version = '25.21.0'
 # incompatible changes are made in the backend library APIs themselves.
 folks_eds_lib_version = '25.21.0'
 folks_telepathy_lib_version = '25.21.0'
-folks_tracker_lib_version = '25.21.0'
 folks_dummy_lib_version = '25.21.0'
 
 # The module version is used to set the shared object versions
@@ -58,7 +57,6 @@ tests_enabled = get_option('tests')
 installed_tests_enabled = get_option('installed_tests')
 ofono_backend_enabled = get_option('ofono_backend')
 telepathy_backend_enabled = get_option('telepathy_backend')
-tracker_backend_enabled = get_option('tracker_backend')
 zeitgeist_enabled = get_option('zeitgeist')
 import_tool_enabled = get_option('import_tool')
 inspect_tool_enabled = get_option('inspect_tool')
@@ -93,24 +91,6 @@ if telepathy_backend_enabled
   endif
 endif
 
-if tracker_backend_enabled
-  tracker_sparql_accepted_versions = [ '0.16', '0.18', '1.0', '2.0' ]
-  foreach version : tracker_sparql_accepted_versions
-    tracker_sparql_dep = dependency('tracker-sparql-@0@'.format(version),
-      version: '>= 0.15.2',
-      required: false,
-    )
-    if tracker_sparql_dep.found()
-      tracker_sparql_version = version
-      break
-    endif
-  endforeach
-
-  if not tracker_sparql_dep.found()
-    error('Tracker backend enabld, but couldn\'t find tracker-sparql package')
-  endif
-endif
-
 if eds_backend_enabled
   libebook_dep = dependency('libebook-1.2', version: '>=' + min_eds_version)
   libebook_contacts_dep = dependency('libebook-contacts-1.2', version: '>=' + min_eds_version)
@@ -172,14 +152,10 @@ conf.set10('HAVE_BLUEZ', bluez_backend_enabled)
 conf.set10('HAVE_EDS', eds_backend_enabled)
 conf.set10('HAVE_OFONO', ofono_backend_enabled)
 conf.set10('HAVE_TELEPATHY', telepathy_backend_enabled)
-conf.set10('HAVE_TRACKER', tracker_backend_enabled)
 if eds_backend_enabled
   conf.set_quoted('EDS_SOURCES_SERVICE_NAME', eds_sources_service_name)
   conf.set_quoted('EDS_ADDRESS_BOOK_SERVICE_NAME', eds_address_book_service_name)
 endif
-if tracker_backend_enabled
-  conf.set_quoted('TRACKER_SPARQL_MAJOR', tracker_sparql_version)
-endif
 configure_file(output: 'config.h', configuration: conf)
 config_h_dir = include_directories('.')
 
diff --git a/meson_options.txt b/meson_options.txt
index 62a9603c..f631e6bd 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -3,7 +3,6 @@ option('bluez_backend', type: 'boolean', value: true, description: 'build the Bl
 option('eds_backend', type: 'boolean', value: true, description: 'build the E-D-S backend')
 option('ofono_backend', type: 'boolean', value: true, description: 'build the oFono backend')
 option('telepathy_backend', type: 'boolean', value: true, description: 'build the Telepathy backend')
-option('tracker_backend', type: 'boolean', value: false, description: 'build the Tracker backend')
 option('zeitgeist', type: 'boolean', value: false, description: 'build Zeitgeist support in the Telepathy 
backend')
 # Tools
 option('import_tool', type: 'boolean', value: true, description: 'Enable building the meta-contact import 
tool')
diff --git a/po/POTFILES.in b/po/POTFILES.in
index eb3537f0..8b869edc 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -8,7 +8,6 @@ backends/ofono/ofono-backend.vala
 backends/telepathy/lib/tp-lowlevel.c
 backends/telepathy/lib/tpf-persona-store.vala
 backends/telepathy/lib/tpf-persona.vala
-backends/tracker/lib/trf-persona-store.vala
 folks/alias-details.vala
 folks/anti-linkable.vala
 folks/avatar-details.vala
diff --git a/po/POTFILES.skip b/po/POTFILES.skip
index 62769ac3..9e26b88b 100644
--- a/po/POTFILES.skip
+++ b/po/POTFILES.skip
@@ -7,7 +7,6 @@ backends/key-file/kf-persona.c
 backends/ofono/ofono-backend.c
 backends/telepathy/lib/tpf-persona-store.c
 backends/telepathy/lib/tpf-persona.c
-backends/tracker/lib/trf-persona-store.c
 docs/gtk-doc/folks-telepathy/ccomments/tp-lowlevel.c
 folks/alias-details.c
 folks/anti-linkable.c
diff --git a/tests/lib/meson.build b/tests/lib/meson.build
index b61c7db7..c6fb7c38 100644
--- a/tests/lib/meson.build
+++ b/tests/lib/meson.build
@@ -61,6 +61,3 @@ if eds_backend_enabled
   subdir('eds')
 endif
 
-if tracker_backend_enabled
-  subdir('tracker')
-endif
diff --git a/tests/lib/test-case.vala b/tests/lib/test-case.vala
index 838ba8dd..afb98c76 100644
--- a/tests/lib/test-case.vala
+++ b/tests/lib/test-case.vala
@@ -160,8 +160,7 @@ public abstract class Folks.TestCase : Object
         error ("unable to create '%s': %s",
             local, GLib.strerror (GLib.errno));
 
-      /* Unset some things we don't want to inherit. In particular,
-       * Tracker might try to index XDG_*_DIR, which we don't want. */
+      /* Unset some things we don't want to inherit. */
       Environment.unset_variable ("XDG_DESKTOP_DIR");
       Environment.unset_variable ("XDG_DOCUMENTS_DIR");
       Environment.unset_variable ("XDG_DOWNLOAD_DIR");
diff --git a/tests/meson.build b/tests/meson.build
index 6a7fa29c..20afd7a6 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -44,6 +44,3 @@ if eds_backend_enabled
   subdir('eds')
 endif
 
-if tracker_backend_enabled
-  subdir('tracker')
-endif
diff --git a/tests/template.test.in b/tests/template.test.in
index 28421b81..8b9eee8d 100644
--- a/tests/template.test.in
+++ b/tests/template.test.in
@@ -1,3 +1,3 @@
 [Test]
 Type=session
-Exec=env G_ENABLE_DIAGNOSTIC=0 FOLKS_TESTS_INSTALLED=1 G_MESSAGES_DEBUG= 
FOLKS_TEST_EDS_LIBEXECDIR=@libexecdir@ FOLKS_TEST_TRACKER_LIBEXECDIR=@libexecdir@ 
@installed_tests_dir@/@program@
+Exec=env G_ENABLE_DIAGNOSTIC=0 FOLKS_TESTS_INSTALLED=1 G_MESSAGES_DEBUG= 
FOLKS_TEST_EDS_LIBEXECDIR=@libexecdir@ @installed_tests_dir@/@program@
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]