[glib: 3/6] Fix signedness warning in gio/gmenu.c:g_menu_insert_item()




commit 2174bcf00036ab30a34826933895572dba05efb4
Author: Emmanuel Fleury <emmanuel fleury gmail com>
Date:   Tue Nov 17 21:45:34 2020 +0100

    Fix signedness warning in gio/gmenu.c:g_menu_insert_item()
    
    gio/gmenu.c: In function ‘g_menu_insert_item’:
    gio/gmenu.c:165:32: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} 
and ‘guint’ {aka ‘unsigned int’}
      165 |   if (position < 0 || position > menu->items->len)
          |                                ^

 gio/gmenu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gio/gmenu.c b/gio/gmenu.c
index bb5202cd3..c067c7fe7 100644
--- a/gio/gmenu.c
+++ b/gio/gmenu.c
@@ -162,7 +162,7 @@ g_menu_insert_item (GMenu     *menu,
   g_return_if_fail (G_IS_MENU (menu));
   g_return_if_fail (G_IS_MENU_ITEM (item));
 
-  if (position < 0 || position > menu->items->len)
+  if (position < 0 || (guint) position > menu->items->len)
     position = menu->items->len;
 
   new_item.attributes = g_hash_table_ref (item->attributes);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]