[glib/wip/issue2323-2-66: 1/5] giochannel: Fix length_size bounds check




commit f8273b9aded135fe07094faebd527e43851aaf6e
Author: Jan Alexander Steffens (heftig) <jan steffens gmail com>
Date:   Sun Feb 7 23:32:40 2021 +0100

    giochannel: Fix length_size bounds check
    
    The inverted condition is an obvious error introduced by ecdf91400e9a.
    
    Fixes https://gitlab.gnome.org/GNOME/glib/-/issues/2323
    
    (cherry picked from commit a149bf2f9030168051942124536e303af8ba6176)

 glib/giochannel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/glib/giochannel.c b/glib/giochannel.c
index 4dec20f77..c3f3102ff 100644
--- a/glib/giochannel.c
+++ b/glib/giochannel.c
@@ -900,7 +900,7 @@ g_io_channel_set_line_term (GIOChannel      *channel,
     {
       /* FIXME: We’re constrained by line_term_len being a guint here */
       gsize length_size = strlen (line_term);
-      g_return_if_fail (length_size > G_MAXUINT);
+      g_return_if_fail (length_size <= G_MAXUINT);
       length_unsigned = (guint) length_size;
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]