[glib/wip/tlspassword: 1/2] gtlspassword: Fix inverted assertion
- From: Simon McVittie <smcv src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/wip/tlspassword: 1/2] gtlspassword: Fix inverted assertion
- Date: Mon, 8 Feb 2021 10:25:16 +0000 (UTC)
commit 61bb52ec42de1082bfb06ce1c737fc295bfe60b8
Author: Simon McVittie <smcv collabora com>
Date: Mon Feb 8 10:04:48 2021 +0000
gtlspassword: Fix inverted assertion
The intention here was to assert that the length of the password fits
in a gssize. Passwords more than half the size of virtual memory are
probably excessive.
Fixes: a8b204ff "gtlspassword: Forbid very long TLS passwords"
Signed-off-by: Simon McVittie <smcv collabora com>
gio/gtlspassword.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gio/gtlspassword.c b/gio/gtlspassword.c
index f5e02a1a8..948e812df 100644
--- a/gio/gtlspassword.c
+++ b/gio/gtlspassword.c
@@ -290,7 +290,7 @@ g_tls_password_set_value (GTlsPassword *password,
{
/* FIXME: g_tls_password_set_value_full() doesn’t support unsigned gsize */
gsize length_unsigned = strlen ((gchar *) value);
- g_return_if_fail (length_unsigned > G_MAXSSIZE);
+ g_return_if_fail (length_unsigned <= G_MAXSSIZE);
length = (gssize) length_unsigned;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]