[gnome-disk-utility/wip/cdavis/ui-cleanups: 7/31] ui: Replace GtkTable with GtkGrid




commit 5d174f11b5ad6e498fbaeefa3675158704cfd5f0
Author: Christopher Davis <brainblasted disroot org>
Date:   Tue Feb 2 17:36:10 2021 -0800

    ui: Replace GtkTable with GtkGrid
    
    GtkTable is deprecated and gone in GTK4; All functionality
    is replaced by GtkGrid.

 src/disks/ui/disks.ui | 248 ++++++++++++--------------------------------------
 1 file changed, 58 insertions(+), 190 deletions(-)
---
diff --git a/src/disks/ui/disks.ui b/src/disks/ui/disks.ui
index c28f9dad..eaca4f5e 100644
--- a/src/disks/ui/disks.ui
+++ b/src/disks/ui/disks.ui
@@ -228,12 +228,11 @@
                         <property name="orientation">vertical</property>
                         <property name="spacing">12</property>
                         <child>
-                          <object class="GtkTable" id="devtab-drive-table">
+                          <object class="GtkGrid" id="devtab-drive-table">
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
-                            <property name="n_rows">12</property>
-                            <property name="n_columns">2</property>
-                            <property name="column_spacing">10</property>
+                            <property name="column_spacing">12</property>
+                            <property name="margin_top">6</property>
                             <child>
                               <object class="GtkLabel" id="devtab-drive-model-label">
                                 <property name="visible">True</property>
@@ -245,9 +244,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">0</property>
                               </packing>
                             </child>
                             <child>
@@ -261,10 +259,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">0</property>
                               </packing>
                             </child>
                             <child>
@@ -278,11 +273,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">7</property>
-                                <property name="bottom_attach">8</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">1</property>
                               </packing>
                             </child>
                             <child>
@@ -296,12 +288,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">7</property>
-                                <property name="bottom_attach">8</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">1</property>
                               </packing>
                             </child>
                             <child>
@@ -315,11 +302,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">8</property>
-                                <property name="bottom_attach">9</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">2</property>
                               </packing>
                             </child>
                             <child>
@@ -333,12 +317,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">8</property>
-                                <property name="bottom_attach">9</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">2</property>
                               </packing>
                             </child>
                             <child>
@@ -352,11 +331,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">9</property>
-                                <property name="bottom_attach">10</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">3</property>
                               </packing>
                             </child>
                             <child>
@@ -370,12 +346,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">9</property>
-                                <property name="bottom_attach">10</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">3</property>
                               </packing>
                             </child>
                             <child>
@@ -389,11 +360,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">1</property>
-                                <property name="bottom_attach">2</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">4</property>
                               </packing>
                             </child>
                             <child>
@@ -407,12 +375,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">1</property>
-                                <property name="bottom_attach">2</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">4</property>
                               </packing>
                             </child>
                             <child>
@@ -426,11 +389,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">10</property>
-                                <property name="bottom_attach">11</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">5</property>
                               </packing>
                             </child>
                             <child>
@@ -444,12 +404,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">10</property>
-                                <property name="bottom_attach">11</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">5</property>
                               </packing>
                             </child>
                             <child>
@@ -464,11 +419,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">11</property>
-                                <property name="bottom_attach">12</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options">GTK_FILL</property>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">6</property>
                               </packing>
                             </child>
                             <child>
@@ -545,10 +497,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">11</property>
-                                <property name="bottom_attach">12</property>
-                                <property name="y_options"/>
+                                <property name="top_attach">6</property>
                               </packing>
                             </child>
                             <child>
@@ -562,11 +511,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">2</property>
-                                <property name="bottom_attach">3</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">7</property>
                               </packing>
                             </child>
                             <child>
@@ -580,12 +526,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">2</property>
-                                <property name="bottom_attach">3</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">7</property>
                               </packing>
                             </child>
                             <child>
@@ -599,11 +540,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">3</property>
-                                <property name="bottom_attach">4</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">8</property>
                               </packing>
                             </child>
                             <child>
@@ -617,12 +555,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">3</property>
-                                <property name="bottom_attach">4</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">8</property>
                               </packing>
                             </child>
                             <child>
@@ -636,11 +569,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">5</property>
-                                <property name="bottom_attach">6</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">9</property>
                               </packing>
                             </child>
                             <child>
@@ -662,11 +592,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">5</property>
-                                <property name="bottom_attach">6</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
+                                <property name="top_attach">9</property>
                               </packing>
                             </child>
                             <child>
@@ -680,11 +606,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">6</property>
-                                <property name="bottom_attach">7</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">10</property>
                               </packing>
                             </child>
                             <child>
@@ -698,12 +621,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">6</property>
-                                <property name="bottom_attach">7</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">10</property>
                               </packing>
                             </child>
                             <child>
@@ -717,11 +635,8 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="top_attach">4</property>
-                                <property name="bottom_attach">5</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="left_attach">0</property>
+                                <property name="top_attach">11</property>
                               </packing>
                             </child>
                             <child>
@@ -735,12 +650,7 @@
                               </object>
                               <packing>
                                 <property name="left_attach">1</property>
-                                <property name="right_attach">2</property>
-                                <property name="top_attach">4</property>
-                                <property name="bottom_attach">5</property>
-                                <property name="x_options">GTK_FILL</property>
-                                <property name="y_options"/>
-                                <property name="y_padding">4</property>
+                                <property name="top_attach">11</property>
                               </packing>
                             </child>
                           </object>
@@ -944,12 +854,11 @@
                               </packing>
                             </child>
                             <child>
-                              <object class="GtkTable" id="devtab-table">
+                              <object class="GtkGrid" id="devtab-table">
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
-                                <property name="n_rows">6</property>
-                                <property name="n_columns">2</property>
-                                <property name="column_spacing">10</property>
+                                <property name="column_spacing">12</property>
+                                <property name="margin_top">6</property>
                                 <child>
                                   <object class="GtkLabel" id="devtab-size-label">
                                     <property name="visible">True</property>
@@ -961,9 +870,8 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="left_attach">0</property>
+                                    <property name="top_attach">0</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -977,10 +885,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="top_attach">0</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -994,11 +899,8 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="top_attach">4</property>
-                                    <property name="bottom_attach">5</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="left_attach">0</property>
+                                    <property name="top_attach">1</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1012,12 +914,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
-                                    <property name="top_attach">4</property>
-                                    <property name="bottom_attach">5</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="top_attach">1</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1031,11 +928,8 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="top_attach">1</property>
-                                    <property name="bottom_attach">2</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="left_attach">0</property>
+                                    <property name="top_attach">2</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1049,12 +943,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
-                                    <property name="top_attach">1</property>
-                                    <property name="bottom_attach">2</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="top_attach">2</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1068,11 +957,8 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="top_attach">2</property>
-                                    <property name="bottom_attach">3</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="left_attach">0</property>
+                                    <property name="top_attach">3</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1086,12 +972,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
-                                    <property name="top_attach">2</property>
-                                    <property name="bottom_attach">3</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="top_attach">3</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1105,11 +986,8 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="top_attach">3</property>
-                                    <property name="bottom_attach">4</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="left_attach">0</property>
+                                    <property name="top_attach">4</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1123,12 +1001,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
-                                    <property name="top_attach">3</property>
-                                    <property name="bottom_attach">4</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_options"/>
-                                    <property name="y_padding">4</property>
+                                    <property name="top_attach">4</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1143,10 +1016,8 @@
                                     </style>
                                   </object>
                                   <packing>
+                                    <property name="left_attach">0</property>
                                     <property name="top_attach">5</property>
-                                    <property name="bottom_attach">6</property>
-                                    <property name="x_options">GTK_FILL</property>
-                                    <property name="y_padding">4</property>
                                   </packing>
                                 </child>
                                 <child>
@@ -1223,10 +1094,7 @@
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
-                                    <property name="right_attach">2</property>
                                     <property name="top_attach">5</property>
-                                    <property name="bottom_attach">6</property>
-                                    <property name="y_options">GTK_FILL</property>
                                   </packing>
                                 </child>
                               </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]