[gnome-shell/wip/jimmac/app-icon-shadows] appDisplay: Revisit "Add drop shadow to icons"




commit 4d274a992ad2ac45743122d2a6cd7653b212c1bf
Author: Florian Müllner <fmuellner gnome org>
Date:   Mon Aug 31 20:54:37 2020 +0200

    appDisplay: Revisit "Add drop shadow to icons"
    
    The shadow is barely visible on dark backgrounds, but it's not
    wrong to be consistent with Settings, Software and GNOME Classic.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3123
    
    Despite performance implications (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3124)
    with the app swarm gone, the patch addresses https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3670

 js/ui/appDisplay.js | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 69b4d0fff5..3b4e0bafcb 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1424,7 +1424,11 @@ var AppSearchProvider = class AppSearchProvider {
                 metas.push({
                     id: app.get_id(),
                     name: app.get_name(),
-                    createIcon: size => app.create_icon_texture(size),
+                    createIcon: size => {
+                        const icon = app.create_icon_texture(size);
+                        icon.add_style_class_name('icon-dropshadow');
+                        return icon;
+                    },
                 });
             } else {
                 let name = this._systemActions.getName(id);
@@ -2688,7 +2692,9 @@ var AppIcon = GObject.registerClass({
     }
 
     _createIcon(iconSize) {
-        return this.app.create_icon_texture(iconSize);
+        const icon = this.app.create_icon_texture(iconSize);
+        icon.add_style_class_name('icon-dropshadow');
+        return icon;
     }
 
     _removeMenuTimeout() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]