[gnome-software: 23/25] gs-plugin-loader: Remove class vfuncs for signals




commit d26326a18c703197271f2dd41db6ee6b75fb171c
Author: Philip Withnall <pwithnall endlessos org>
Date:   Tue Feb 2 12:35:40 2021 +0000

    gs-plugin-loader: Remove class vfuncs for signals
    
    They’re unused and generally only used in derived classes. There are no
    classes derived from `GsPluginLoader`, and it seems unlikely there ever
    will be.
    
    This simplifies the code a little.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 lib/gs-plugin-loader.c | 15 +++++----------
 lib/gs-plugin-loader.h | 11 -----------
 2 files changed, 5 insertions(+), 21 deletions(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 3767f37d8..0e9792685 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -2806,32 +2806,27 @@ gs_plugin_loader_class_init (GsPluginLoaderClass *klass)
        signals [SIGNAL_STATUS_CHANGED] =
                g_signal_new ("status-changed",
                              G_TYPE_FROM_CLASS (object_class), G_SIGNAL_RUN_LAST,
-                             G_STRUCT_OFFSET (GsPluginLoaderClass, status_changed),
-                             NULL, NULL, g_cclosure_marshal_generic,
+                             0, NULL, NULL, g_cclosure_marshal_generic,
                              G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_UINT);
        signals [SIGNAL_PENDING_APPS_CHANGED] =
                g_signal_new ("pending-apps-changed",
                              G_TYPE_FROM_CLASS (object_class), G_SIGNAL_RUN_LAST,
-                             G_STRUCT_OFFSET (GsPluginLoaderClass, pending_apps_changed),
-                             NULL, NULL, g_cclosure_marshal_VOID__VOID,
+                             0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                              G_TYPE_NONE, 0);
        signals [SIGNAL_UPDATES_CHANGED] =
                g_signal_new ("updates-changed",
                              G_TYPE_FROM_CLASS (object_class), G_SIGNAL_RUN_LAST,
-                             G_STRUCT_OFFSET (GsPluginLoaderClass, updates_changed),
-                             NULL, NULL, g_cclosure_marshal_VOID__VOID,
+                             0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                              G_TYPE_NONE, 0);
        signals [SIGNAL_RELOAD] =
                g_signal_new ("reload",
                              G_TYPE_FROM_CLASS (object_class), G_SIGNAL_RUN_LAST,
-                             G_STRUCT_OFFSET (GsPluginLoaderClass, reload),
-                             NULL, NULL, g_cclosure_marshal_VOID__VOID,
+                             0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                              G_TYPE_NONE, 0);
        signals [SIGNAL_BASIC_AUTH_START] =
                g_signal_new ("basic-auth-start",
                              G_TYPE_FROM_CLASS (object_class), G_SIGNAL_RUN_LAST,
-                             G_STRUCT_OFFSET (GsPluginLoaderClass, basic_auth_start),
-                             NULL, NULL, g_cclosure_marshal_generic,
+                             0, NULL, NULL, g_cclosure_marshal_generic,
                              G_TYPE_NONE, 4, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_POINTER, G_TYPE_POINTER);
 }
 
diff --git a/lib/gs-plugin-loader.h b/lib/gs-plugin-loader.h
index 7019d1de6..92654150a 100644
--- a/lib/gs-plugin-loader.h
+++ b/lib/gs-plugin-loader.h
@@ -27,17 +27,6 @@ G_DECLARE_DERIVABLE_TYPE (GsPluginLoader, gs_plugin_loader, GS, PLUGIN_LOADER, G
 struct _GsPluginLoaderClass
 {
        GObjectClass             parent_class;
-       void                    (*status_changed)       (GsPluginLoader *plugin_loader,
-                                                        GsApp          *app,
-                                                        GsPluginStatus  status);
-       void                    (*pending_apps_changed) (GsPluginLoader *plugin_loader);
-       void                    (*updates_changed)      (GsPluginLoader *plugin_loader);
-       void                    (*reload)               (GsPluginLoader *plugin_loader);
-       void                    (*basic_auth_start)     (GsPluginLoader *plugin_loader,
-                                                        const gchar    *remote,
-                                                        const gchar    *realm,
-                                                        GCallback       callback,
-                                                        gpointer        user_data);
 };
 
 GsPluginLoader *gs_plugin_loader_new                   (void);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]