[gnome-software: 10/25] core: Drop desktop-menu-path plugin

[Philip Withnall <pwithnall src gnome org>]

commit 09e9e40c0987801f64331c871c5c189fae15e9c9
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Feb 1 23:19:50 2021 +0000

    core: Drop desktop-menu-path plugin
    
    After the refactoring in the previous few commits, it’s now empty and
    redundant.
    
    Each plugin dropped from gnome-software speeds up *every* plugin job,
    since the code iterated through all loaded plugins and tried calling
    the vfunc for each job on each of them.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 contrib/gnome-software.spec.in             |  1 -
 plugins/core/gs-plugin-desktop-menu-path.c | 27 ---------------------------
 plugins/core/meson.build                   | 13 -------------
 plugins/dummy/gs-self-test.c               |  1 -
 4 files changed, 42 deletions(-)
---
diff --git a/contrib/gnome-software.spec.in b/contrib/gnome-software.spec.in
index c274b5585..0eb686106 100644
--- a/contrib/gnome-software.spec.in
+++ b/contrib/gnome-software.spec.in
@@ -150,7 +150,6 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop
 %{_datadir}/metainfo/org.gnome.Software.Plugin.Odrs.metainfo.xml
 %dir %{_libdir}/gs-plugins-%{gs_plugin_version}
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_appstream.so
-%{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_desktop-menu-path.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_dummy.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_fedora-langpacks.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_fedora-pkgdb-collections.so
diff --git a/plugins/core/meson.build b/plugins/core/meson.build
index 331ac2a33..ced459f2b 100644
--- a/plugins/core/meson.build
+++ b/plugins/core/meson.build
@@ -98,19 +98,6 @@ shared_module(
   ],
 )
 
-shared_module(
-  'gs_plugin_desktop-menu-path',
-  sources : 'gs-plugin-desktop-menu-path.c',
-  include_directories : [
-    include_directories('../..'),
-    include_directories('../../lib'),
-  ],
-  install : true,
-  install_dir: plugin_dir,
-  c_args : cargs,
-  dependencies : plugin_libs,
-)
-
 shared_module(
   'gs_plugin_hardcoded-blocklist',
   sources : 'gs-plugin-hardcoded-blocklist.c',
diff --git a/plugins/dummy/gs-self-test.c b/plugins/dummy/gs-self-test.c
index 10748003c..98a653714 100644
--- a/plugins/dummy/gs-self-test.c
+++ b/plugins/dummy/gs-self-test.c
@@ -724,7 +724,6 @@ main (int argc, char **argv)
                "dummy",
                "generic-updates",
                "hardcoded-blocklist",
-               "desktop-menu-path",
                "icons",
                "key-colors",
                "provenance",