[gnome-shell-sass] appDisplay: Fix app folder icon subicon spacing
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-sass] appDisplay: Fix app folder icon subicon spacing
- Date: Wed, 3 Feb 2021 12:19:28 +0000 (UTC)
commit e85dda0fa1b080d269adfcb9dce7cf6d05c0d00a
Author: Sebastian Keller <skeller gnome org>
Date: Wed Jan 20 02:03:49 2021 +0100
appDisplay: Fix app folder icon subicon spacing
The code previously was using CSS to define row/column spacing and
padding which was combined with a subicon size computed in code relative
to the requested icon size.
In smaller icon sizes it was possible for the CSS spacing+padding + the
size of the two subicons to exceed the requested icon size. This then
would lead to the label being pushed down for app folders compared to
other icons.
Another more severe issue caused by this would happen if the first item
in an icon grid was an app folder. Then the calculation for the maximum
allowed icon size could be off, leading to all icons in the grid
becoming smaller than actually necessary.
This commit changes this to use homogeneous row and column layouts to
evenly distribute the remaining spacing instead of using a fixed CSS
value.
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3069
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1581>
widgets/_app-grid.scss | 7 -------
1 file changed, 7 deletions(-)
---
diff --git a/widgets/_app-grid.scss b/widgets/_app-grid.scss
index ba7c521..13eb926 100644
--- a/widgets/_app-grid.scss
+++ b/widgets/_app-grid.scss
@@ -89,13 +89,6 @@ $app_grid_fg_color: #fff;
height: 620px;
}
-.app-folder-icon {
- padding: $base_padding;
- spacing-rows: $base_spacing;
- spacing-columns: $base_spacing;
-}
-
-
// Running app indicator (also shown in dash)
.app-well-app-running-dot {
height: 5px;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]