[gnome-shell/wip/jimmac/dash-icon-spacing: 4/72] overviewControls: Simplify DashFader

[Jakub Steiner <jimmac src gnome org>]

commit 37feee175f6a16f08eb8139e0094034b7091095e
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Fri Dec 11 09:59:46 2020 -0300

    overviewControls: Simplify DashFader
    
    Merge FaderControl and DashFader, since it's the only subclass, and
    remove all overview connections that aren't useful for it.

 js/ui/overviewControls.js | 67 +++++++++++------------------------------------
 1 file changed, 15 insertions(+), 52 deletions(-)
---
diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index d51404e284..af420c5289 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -10,57 +10,8 @@ const Overview = imports.ui.overview;
 
 var SIDE_CONTROLS_ANIMATION_TIME = Overview.ANIMATION_TIME;
 
-var FaderControl = GObject.registerClass(
-class FaderControl extends St.Widget {
-    _init(params) {
-        super._init(params);
-
-        this._inDrag = false;
-
-        Main.overview.connect('item-drag-begin', this._onDragBegin.bind(this));
-        Main.overview.connect('item-drag-end', this._onDragEnd.bind(this));
-        Main.overview.connect('item-drag-cancelled', this._onDragEnd.bind(this));
-
-        Main.overview.connect('window-drag-begin', this._onWindowDragBegin.bind(this));
-        Main.overview.connect('window-drag-cancelled', this._onWindowDragEnd.bind(this));
-        Main.overview.connect('window-drag-end', this._onWindowDragEnd.bind(this));
-    }
-
-    _onWindowDragBegin() {
-        this._onDragBegin();
-    }
-
-    _onWindowDragEnd() {
-        this._onDragEnd();
-    }
-
-    _onDragBegin() {
-        this._inDrag = true;
-    }
-
-    _onDragEnd() {
-        this._inDrag = false;
-    }
-
-    fadeIn() {
-        this.ease({
-            opacity: 255,
-            duration: SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_IN_QUAD,
-        });
-    }
-
-    fadeHalf() {
-        this.ease({
-            opacity: 128,
-            duration: SIDE_CONTROLS_ANIMATION_TIME / 2,
-            mode: Clutter.AnimationMode.EASE_OUT_QUAD,
-        });
-    }
-});
-
 var DashFader = GObject.registerClass(
-class DashFader extends FaderControl {
+class DashFader extends St.Widget {
     _init(dash) {
         super._init({
             x_expand: true,
@@ -70,14 +21,26 @@ class DashFader extends FaderControl {
 
         this._dash = dash;
         this.add_child(this._dash);
+
+        Main.overview.connect('window-drag-begin', this._onWindowDragBegin.bind(this));
+        Main.overview.connect('window-drag-cancelled', this._onWindowDragEnd.bind(this));
+        Main.overview.connect('window-drag-end', this._onWindowDragEnd.bind(this));
     }
 
     _onWindowDragBegin() {
-        this.fadeHalf();
+        this.ease({
+            opacity: 128,
+            duration: SIDE_CONTROLS_ANIMATION_TIME / 2,
+            mode: Clutter.AnimationMode.EASE_OUT_QUAD,
+        });
     }
 
     _onWindowDragEnd() {
-        this.fadeIn();
+        this.ease({
+            opacity: 255,
+            duration: SIDE_CONTROLS_ANIMATION_TIME / 2,
+            mode: Clutter.AnimationMode.EASE_IN_QUAD,
+        });
     }
 });