[vala/staging] codegen: Don't leak array memory after it was implicitly copied
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/staging] codegen: Don't leak array memory after it was implicitly copied
- Date: Tue, 2 Feb 2021 09:40:34 +0000 (UTC)
commit 105f1c3258fd896fdbaa462a836283d3a3dd06a6
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Tue Feb 2 10:34:54 2021 +0100
codegen: Don't leak array memory after it was implicitly copied
Found by -fsanitize=address
codegen/valaccodebasemodule.vala | 5 +++++
1 file changed, 5 insertions(+)
---
diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 61e831ff9..cb4550942 100644
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -6154,6 +6154,11 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
Report.error (node.source_reference, "missing class prerequisite for
interface `%s', add GLib.Object to interface declaration if unsure", target_type.type_symbol.get_full_name
());
return result;
}
+ // need to free old array after copying it
+ if (array_needs_copy && requires_destroy (type)) {
+ result.value_type = type.copy ();
+ ccode.add_expression (destroy_value (result));
+ }
result = copy;
// implicit array copying is deprecated, but allow it for internal codegen usage
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]