[gnome-shell/wip/snwh/style-updates] theme: some light variant fixes

[Sam Hewitt <snwh src gnome org>]

commit ee623ca3ea64ab3d12bc1229ec85af6914122b3f
Author: Sam Hewitt <sam snwh org>
Date:   Wed Dec 29 10:06:57 2021 -0330

    theme: some light variant fixes

 data/theme/gnome-shell-sass/_colors.scss                 |  6 +++---
 data/theme/gnome-shell-sass/_drawing.scss                |  3 ++-
 data/theme/gnome-shell-sass/widgets/_dash.scss           | 14 +++-----------
 data/theme/gnome-shell-sass/widgets/_search-entry.scss   |  3 +--
 data/theme/gnome-shell-sass/widgets/_search-results.scss |  1 +
 5 files changed, 10 insertions(+), 17 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/_colors.scss b/data/theme/gnome-shell-sass/_colors.scss
index 3f6e8cd484..801a2f2522 100644
--- a/data/theme/gnome-shell-sass/_colors.scss
+++ b/data/theme/gnome-shell-sass/_colors.scss
@@ -2,11 +2,11 @@
 // it gets @if-ed depending on $variant
 
 $base_color: if($variant == 'light', #fff, lighten(desaturate(#242424, 20%), 2%));
-$bg_color: if($variant == 'light', #fafafa, #242424);
+$bg_color: if($variant == 'light', #f6f5f4, #242424);
 $fg_color: if($variant == 'light', transparentize(black, .2), white);
 
 $selected_fg_color: #fff;
-$selected_bg_color: if($variant == 'light', #1c71d8, darken(#1c71d8, 10%));
+$selected_bg_color: if($variant == 'light', #3584e4, #1c71d8);
 $selected_borders_color: if($variant== 'light', darken($selected_bg_color, 15%), darken($selected_bg_color, 
30%));
 $borders_color: if($variant == 'light', darken($bg_color, 12%), darken($bg_color, 5%));
 $borders_edge: if($variant == 'light', rgba(255,255,255,0.8), transparentize($fg_color, 0.93));
@@ -28,7 +28,7 @@ $osd_borders_color: transparentize(black, 0.3);
 $osd_outer_borders_color: transparentize(white, 0.84);
 
 $shadow_color: if($variant == 'light', rgba(0,0,0,0.1), rgba(0,0,0,0.2));
-$system_bg_color: darken(#242424, 2%);
+$system_bg_color: if($variant == 'light', #9a9996, darken(#242424, 2%)); 
 
 //insensitive state derived colors
 $insensitive_fg_color: mix($fg_color, $bg_color, 50%);
diff --git a/data/theme/gnome-shell-sass/_drawing.scss b/data/theme/gnome-shell-sass/_drawing.scss
index f09eb123f2..c89dd76ad5 100644
--- a/data/theme/gnome-shell-sass/_drawing.scss
+++ b/data/theme/gnome-shell-sass/_drawing.scss
@@ -196,7 +196,7 @@
 }
 
 // overview icons
-@mixin overview-icon($color) {
+@mixin overview_icon($color) {
   .overview-icon {
     @extend %icon_tile;
     color: $color;
@@ -223,6 +223,7 @@
     }
   }
 
+  &:focus,
   &:active,
   &:checked {
     .overview-icon {
diff --git a/data/theme/gnome-shell-sass/widgets/_dash.scss b/data/theme/gnome-shell-sass/widgets/_dash.scss
index d3a5c6c8ad..1d36122c32 100644
--- a/data/theme/gnome-shell-sass/widgets/_dash.scss
+++ b/data/theme/gnome-shell-sass/widgets/_dash.scss
@@ -1,6 +1,6 @@
 /* Dash */
 
-$dash_background_color: lighten($bg_color, 5%);
+$dash_background_color: lighten($system_bg_color, 5%);
 $dash_placeholder_size: 32px;
 $dash_padding: $base_padding + 4px; // 10px
 $dash_spacing: $base_padding / 4;
@@ -31,9 +31,9 @@ $dash_border_radius: $modal_radius + 6;
 
 .dash-background {
   background-color: $dash_background_color;
+  border-radius: $dash_border_radius;
   margin-bottom: $dash_bottom_margin;
   padding: $dash_padding;
-  border-radius: $dash_border_radius;
 }
 
 // Dash Items
@@ -59,13 +59,5 @@ $dash_border_radius: $modal_radius + 6;
 
 // Show apps button
 .show-apps {
-  @include overview-icon($osd_fg_color);
-
-  &:focus,
-  &:checked {
-    .overview-icon {
-      background-color: transparentize($osd_bg_color,0.5);
-      color: $fg_color;
-    }
-  }
+  @include overview_icon($osd_fg_color);
 }
diff --git a/data/theme/gnome-shell-sass/widgets/_search-entry.scss 
b/data/theme/gnome-shell-sass/widgets/_search-entry.scss
index ef4d147cc1..0273845804 100644
--- a/data/theme/gnome-shell-sass/widgets/_search-entry.scss
+++ b/data/theme/gnome-shell-sass/widgets/_search-entry.scss
@@ -23,9 +23,8 @@ $search_entry_height: 36px;
   &:focus {
     border-style: solid;
     border-color: $selected_bg_color;
-    background-color: transparentize($selected_bg_color, 0.9);
     color: $fg_color;
-    box-shadow:none;
+    box-shadow: inset 0 99px 0 0 transparentize($selected_bg_color, 0.8);
   }
 
   .search-entry-icon { 
diff --git a/data/theme/gnome-shell-sass/widgets/_search-results.scss 
b/data/theme/gnome-shell-sass/widgets/_search-results.scss
index a1f5690eb8..dfe5eb8eaa 100644
--- a/data/theme/gnome-shell-sass/widgets/_search-results.scss
+++ b/data/theme/gnome-shell-sass/widgets/_search-results.scss
@@ -31,6 +31,7 @@
   padding: $base_padding * 3;
   // This is the space between the provider icon and the results container
   spacing: $base_margin * 2;
+  margin: $base_margin;
 }
 
 %search_section_content_item {