[libsoup/wip/smcv/save-server-root: 1/2] test-utils: Log Apache arguments
- From: Simon McVittie <smcv src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup/wip/smcv/save-server-root: 1/2] test-utils: Log Apache arguments
- Date: Mon, 27 Dec 2021 18:13:42 +0000 (UTC)
commit 37709bd3e042f057ff5ca21e2aa32a4db47bb5e7
Author: Simon McVittie <smcv debian org>
Date: Mon Dec 27 16:24:55 2021 +0000
test-utils: Log Apache arguments
This helped to diagnose a use-after-free bug in the unit tests.
Signed-off-by: Simon McVittie <smcv debian org>
tests/test-utils.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
---
diff --git a/tests/test-utils.c b/tests/test-utils.c
index 89782ef5..38ff8bc3 100644
--- a/tests/test-utils.c
+++ b/tests/test-utils.c
@@ -170,6 +170,8 @@ apache_cmd (const char *cmd)
#endif
int status;
gboolean ok;
+ GString *str;
+ guint i;
server_root = soup_test_build_filename_abs (G_TEST_BUILT, "", NULL);
@@ -197,6 +199,18 @@ apache_cmd (const char *cmd)
g_ptr_array_add (argv, (char *)cmd);
g_ptr_array_add (argv, NULL);
+ str = g_string_new ("Apache command:");
+
+ for (i = 0; i < argv->len - 1; i++) {
+ char *escaped = g_shell_quote (argv->pdata[i]);
+ g_string_append_c (str, ' ');
+ g_string_append (str, escaped);
+ g_free (escaped);
+ }
+
+ g_test_message ("%s", str->str);
+ g_string_free (str, TRUE);
+
ok = g_spawn_sync (cwd, (char **)argv->pdata, NULL, 0, NULL, NULL,
NULL, NULL, &status, NULL);
if (ok)
@@ -210,6 +224,7 @@ apache_cmd (const char *cmd)
#endif
g_ptr_array_free (argv, TRUE);
+ g_test_message (ok ? "-> success" : "-> failed");
return ok;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]