[goffice] canvas: plug leak.



commit 86a8dffb723cbee876fd8a6c03643e98a8d82a50
Author: Morten Welinder <terra gnome org>
Date:   Sun Dec 26 19:02:48 2021 -0500

    canvas: plug leak.

 ChangeLog                  | 11 +++++++++--
 goffice/canvas/goc-group.c |  2 +-
 2 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 7fb1cd78..efbd74cd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2021-12-26  Morten Welinder  <terra gnome org>
+
+       * goffice/canvas/goc-group.c (goc_group_fake_xchildren): Plug
+       leak.
+
 2021-12-02  Morten Welinder  <terra gnome org>
 
        * goffice/utils/go-glib-extras.c (go_memdup_n): New function.
@@ -7,13 +12,15 @@
        * goffice/utils/go-emf.c (go_emf_load_data): Use go_memdup.
        (go_emf_new_from_data): Ditto.
 
-       * goffice/component/go-component.c (go_component_duplicate): Use go_memdup.
+       * goffice/component/go-component.c (go_component_duplicate): Use
+       go_memdup.
 
        * goffice/data/go-data-simple.c (go_data_vector_str_new_copy): Use
        g_new, not g_malloc.
        (go_data_vector_val_new_copy): Use go_memdup_n.
 
-       * goffice/canvas/goc-group.c (goc_group_init): Use g_new0, not g_malloc0.
+       * goffice/canvas/goc-group.c (goc_group_init): Use g_new0, not
+       g_malloc0.
 
 2021-12-01  Morten Welinder  <terra gnome org>
 
diff --git a/goffice/canvas/goc-group.c b/goffice/canvas/goc-group.c
index f138c8fd..1976cf1a 100644
--- a/goffice/canvas/goc-group.c
+++ b/goffice/canvas/goc-group.c
@@ -387,7 +387,7 @@ static void
 goc_group_fake_xchildren (GocGroup *group)
 {
        g_list_free (group->Xchildren);
-       group->Xchildren = group->priv->children
+       group->Xchildren = group->priv->children->len
                ? g_list_prepend (NULL, goc_group_get_child (group, 0))
                : NULL;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]