[gtk/wip/chergert/4575-fix-texthistory-selection: 3/4] texthistory: always track selection bounds




commit e7871fbc433fad592e227ead834346aa3db8a235
Author: Christian Hergert <chergert redhat com>
Date:   Sun Dec 26 12:47:45 2021 -0800

    texthistory: always track selection bounds
    
    It's cheap to store the selection position, so always set it even if we
    are in a user section. Otherwise, we risk not having the right position
    when starting a delete action within a begin_user_action(),
    end_user_action() pair.
    
    Related #4575

 gtk/gtktexthistory.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/gtk/gtktexthistory.c b/gtk/gtktexthistory.c
index 3b9379ccc3..5f3f2cb56c 100644
--- a/gtk/gtktexthistory.c
+++ b/gtk/gtktexthistory.c
@@ -981,11 +981,8 @@ gtk_text_history_selection_changed (GtkTextHistory *self,
   return_if_applying (self);
   return_if_irreversible (self);
 
-  if (self->in_user == 0 && self->irreversible == 0)
-    {
-      self->selection.insert = CLAMP (selection_insert, -1, G_MAXINT);
-      self->selection.bound = CLAMP (selection_bound, -1, G_MAXINT);
-    }
+  self->selection.insert = CLAMP (selection_insert, -1, G_MAXINT);
+  self->selection.bound = CLAMP (selection_bound, -1, G_MAXINT);
 }
 
 void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]