[balsa/gtk4: 146/311] Various: Stop using GtkBox child properties
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa/gtk4: 146/311] Various: Stop using GtkBox child properties
- Date: Fri, 17 Dec 2021 19:54:01 +0000 (UTC)
commit 4278190416d8de5fdb53f2aa426bf091daa66d34
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Sat Jun 6 17:40:54 2020 -0400
Various: Stop using GtkBox child properties
Stop using GtkBox padding, fill and expand child properties
Apparently, when the child is a GtkScrolledWindow, we must use
container_add(…) instead of pack_start(…, FALSE, FALSE, 0).
* libbalsa/address.c (libbalsa_address_get_edit_widget):
* libbalsa/autocrypt.c (autocrypt_db_dialog_run):
* libbalsa/html.c (libbalsa_html_new):
ChangeLog | 8 ++++++++
libbalsa/address.c | 10 ++++------
libbalsa/html.c | 2 +-
3 files changed, 13 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 3ec0f18a4..2da928b7b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -723,6 +723,14 @@
* libbalsa/autocrypt.c (autocrypt_db_dialog_run):
* libbalsa/html.c (libbalsa_html_new):
+2020-06-06 Peter Bloomfield <pbloomfield bellsouth net>
+
+ Various: Stop using GtkBox padding, fill and expand child properties
+
+ * libbalsa/address.c (libbalsa_address_get_edit_widget):
+ * libbalsa/autocrypt.c (autocrypt_db_dialog_run):
+ * libbalsa/html.c (libbalsa_html_new):
+
2020-06-06 Peter Bloomfield <pbloomfield bellsouth net>
balsa-message: Do not crash
diff --git a/libbalsa/address.c b/libbalsa/address.c
index b7da172c7..a7026cfab 100644
--- a/libbalsa/address.c
+++ b/libbalsa/address.c
@@ -986,12 +986,10 @@ libbalsa_address_get_edit_widget(LibBalsaAddress *address,
GtkWidget *tree_view;
entries[cnt] = lba_addr_list_widget(changed_cb, changed_data);
- gtk_widget_set_margin_top(label, 1);
- gtk_widget_set_margin_bottom(label, 1);
- gtk_container_add(GTK_CONTAINER(box), label);
- gtk_widget_set_margin_top(but, 1);
- gtk_widget_set_margin_bottom(but, 1);
- gtk_container_add(GTK_CONTAINER(box), but);
+ g_object_set(label, "margin", 1, NULL);
+ gtk_box_pack_start(GTK_BOX(box), label, FALSE, FALSE, 0);
+ g_object_set(but, "margin", 1, NULL);
+ gtk_box_pack_start(GTK_BOX(box), but, FALSE, FALSE, 0);
lhs = box;
tree_view = gtk_frame_get_child(GTK_FRAME(entries[cnt]));
g_signal_connect(but, "clicked", G_CALLBACK(add_row), tree_view);
diff --git a/libbalsa/html.c b/libbalsa/html.c
index 3b1389a0d..cf60e7e06 100644
--- a/libbalsa/html.c
+++ b/libbalsa/html.c
@@ -869,7 +869,7 @@ libbalsa_html_new(LibBalsaMessageBody * body,
gtk_widget_set_vexpand(GTK_WIDGET(info->web_view), TRUE);
gtk_widget_set_valign(GTK_WIDGET(info->web_view), GTK_ALIGN_FILL);
- gtk_container_add(GTK_CONTAINER(vbox), GTK_WIDGET(info->web_view));
+ gtk_box_pack_start(GTK_BOX(vbox), GTK_WIDGET(info->web_view), FALSE, FALSE, 0);
webkit_web_view_load_html(info->web_view, text, NULL);
g_free(text);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]