[gnome-control-center] keyboard-manager: fix leak of section list store



commit 7741dc1abe343a3fda624d7194a4ff7902095893
Author: Victor Toso <victortoso redhat com>
Date:   Tue Oct 12 12:36:14 2021 +0200

    keyboard-manager: fix leak of section list store
    
    ==25729== 1,058 (40 direct, 1,018 indirect) bytes in 1 blocks are definitely lost in loss record 20,104 
of 20,657
    ==25729==    at 0x484086F: malloc (vg_replace_malloc.c:380)
    ==25729==    by 0x4AF77A8: g_malloc (gmem.c:106)
    ==25729==    by 0x4B0F1E4: g_slice_alloc (gslice.c:1072)
    ==25729==    by 0x4B09060: UnknownInlinedFun (gsequence.c:1609)
    ==25729==    by 0x4B09060: g_sequence_insert_before (gsequence.c:527)
    ==25729==    by 0x4ED2FE7: gtk_list_store_insert (gtkliststore.c:1271)
    ==25729==    by 0x4A5DCE: append_section (cc-keyboard-manager.c:363)
    ==25729==    by 0x4A605D: append_sections_from_file (cc-keyboard-manager.c:431)
    ==25729==    by 0x4A6766: reload_sections (cc-keyboard-manager.c:568)
    ==25729==    by 0x4A6D33: cc_keyboard_manager_load_shortcuts (cc-keyboard-manager.c:706)
    ==25729==    by 0x4A2FA4: cc_keyboard_shortcut_dialog_init (cc-keyboard-shortcut-dialog.c:841)
    ==25729==    by 0x4A7A288: g_type_create_instance (gtype.c:1929)
    ==25729==    by 0x4A61CAC: g_object_new_internal (gobject.c:1945)

 panels/keyboard/cc-keyboard-manager.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/panels/keyboard/cc-keyboard-manager.c b/panels/keyboard/cc-keyboard-manager.c
index 8497d7a87..7e3b3fb76 100644
--- a/panels/keyboard/cc-keyboard-manager.c
+++ b/panels/keyboard/cc-keyboard-manager.c
@@ -581,6 +581,7 @@ cc_keyboard_manager_finalize (GObject *object)
   g_clear_pointer (&self->kb_apps_sections, g_hash_table_destroy);
   g_clear_pointer (&self->kb_user_sections, g_hash_table_destroy);
   g_clear_object (&self->binding_settings);
+  g_clear_object (&self->sections_store);
 
   G_OBJECT_CLASS (cc_keyboard_manager_parent_class)->finalize (object);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]