[epiphany/mcatanzaro/more-web-app-fixes: 1/2] web-app-utils: add FIXME comments regarding hyphens
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/more-web-app-fixes: 1/2] web-app-utils: add FIXME comments regarding hyphens
- Date: Thu, 16 Dec 2021 14:07:00 +0000 (UTC)
commit b788929e68b7fbc2cd66fd6a0e26da8729e8335d
Author: Michael Catanzaro <mcatanzaro redhat com>
Date: Thu Dec 16 07:55:42 2021 -0600
web-app-utils: add FIXME comments regarding hyphens
lib/ephy-web-app-utils.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/lib/ephy-web-app-utils.c b/lib/ephy-web-app-utils.c
index e696be0b8..7b50f5a73 100644
--- a/lib/ephy-web-app-utils.c
+++ b/lib/ephy-web-app-utils.c
@@ -65,6 +65,9 @@ ephy_web_application_get_app_id_from_name (const char *name)
g_autofree char *normal_id = NULL;
g_autofree char *checksum = NULL;
+ /* FIXME: We should not use hyphens in app IDs. Sadly, changing this requires
+ * a new migration.
+ */
normal_id = g_utf8_strdown (name, -1);
g_strdelimit (normal_id, " ", '-');
g_strdelimit (normal_id, G_DIR_SEPARATOR_S, '-');
@@ -105,7 +108,7 @@ get_gapplication_id_from_id (const char *id)
g_auto (GStrv) split = NULL;
g_autofree char *gapplication_id = NULL;
- /* Ideally we would convert hyphens to underscores here, because
+ /* FIXME: Ideally we would convert hyphens to underscores here, because
* hyphens are not very friendly to D-Bus. However, changing this
* would require a new profile migration, because the GApplication ID
* must exactly match the desktop file basename.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]