[gnome-software: 2/4] gs-plugin-vfuncs: Remove gs_plugin_app_set_rating()

[Philip Withnall <pwithnall src gnome org>]

commit 5256abff30bf3febc2dfbb0e3ce74bb6ebaf2d1e
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Dec 13 16:56:23 2021 +0000

    gs-plugin-vfuncs: Remove gs_plugin_app_set_rating()
    
    Since the introduction of `GsOdrsProvider` it has been unused, and
    unimplemented by any of the built-in plugins.
    
    This is all dead code.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 lib/gs-plugin-loader.c |  1 -
 lib/gs-plugin-types.h  |  2 --
 lib/gs-plugin-vfuncs.h | 18 ------------------
 lib/gs-plugin.c        |  6 ------
 4 files changed, 27 deletions(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index fea6b7203..1738fba28 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -643,7 +643,6 @@ gs_plugin_loader_call_vfunc (GsPluginLoaderHelper *helper,
                break;
        case GS_PLUGIN_ACTION_INSTALL:
        case GS_PLUGIN_ACTION_REMOVE:
-       case GS_PLUGIN_ACTION_SET_RATING:
        case GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD:
        case GS_PLUGIN_ACTION_UPGRADE_TRIGGER:
        case GS_PLUGIN_ACTION_LAUNCH:
diff --git a/lib/gs-plugin-types.h b/lib/gs-plugin-types.h
index af29d1069..59ce63f60 100644
--- a/lib/gs-plugin-types.h
+++ b/lib/gs-plugin-types.h
@@ -195,7 +195,6 @@ typedef enum {
  * @GS_PLUGIN_ACTION_INSTALL:                  Install an application
  * @GS_PLUGIN_ACTION_REMOVE:                   Remove an application
  * @GS_PLUGIN_ACTION_UPDATE:                   Update an application
- * @GS_PLUGIN_ACTION_SET_RATING:               Set rating on an application
  * @GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD:         Download a distro upgrade
  * @GS_PLUGIN_ACTION_UPGRADE_TRIGGER:          Trigger a distro upgrade
  * @GS_PLUGIN_ACTION_LAUNCH:                   Launch an application
@@ -231,7 +230,6 @@ typedef enum {
        GS_PLUGIN_ACTION_INSTALL,
        GS_PLUGIN_ACTION_REMOVE,
        GS_PLUGIN_ACTION_UPDATE,
-       GS_PLUGIN_ACTION_SET_RATING,
        GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD,
        GS_PLUGIN_ACTION_UPGRADE_TRIGGER,
        GS_PLUGIN_ACTION_LAUNCH,
diff --git a/lib/gs-plugin-vfuncs.h b/lib/gs-plugin-vfuncs.h
index 41c818f0a..ff045738d 100644
--- a/lib/gs-plugin-vfuncs.h
+++ b/lib/gs-plugin-vfuncs.h
@@ -449,24 +449,6 @@ gboolean    gs_plugin_app_remove                   (GsPlugin       *plugin,
                                                         GCancellable   *cancellable,
                                                         GError         **error);
 
-/**
- * gs_plugin_app_set_rating:
- * @plugin: a #GsPlugin
- * @app: a #GsApp
- * @cancellable: a #GCancellable, or %NULL
- * @error: a #GError, or %NULL
- *
- * Gets any ratings for the applications.
- *
- * Plugins are expected to call gs_app_set_rating() on @app.
- *
- * Returns: %TRUE for success or if not relevant
- **/
-gboolean        gs_plugin_app_set_rating               (GsPlugin       *plugin,
-                                                        GsApp          *app,
-                                                        GCancellable   *cancellable,
-                                                        GError         **error);
-
 /**
  * gs_plugin_update_app:
  * @plugin: a #GsPlugin
diff --git a/lib/gs-plugin.c b/lib/gs-plugin.c
index 486aefe3c..c4cdf1168 100644
--- a/lib/gs-plugin.c
+++ b/lib/gs-plugin.c
@@ -1669,8 +1669,6 @@ gs_plugin_action_to_function_name (GsPluginAction action)
                return "gs_plugin_app_install";
        if (action == GS_PLUGIN_ACTION_REMOVE)
                return "gs_plugin_app_remove";
-       if (action == GS_PLUGIN_ACTION_SET_RATING)
-               return "gs_plugin_app_set_rating";
        if (action == GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD)
                return "gs_plugin_app_upgrade_download";
        if (action == GS_PLUGIN_ACTION_UPGRADE_TRIGGER)
@@ -1749,8 +1747,6 @@ gs_plugin_action_to_string (GsPluginAction action)
                return "remove";
        if (action == GS_PLUGIN_ACTION_UPDATE)
                return "update";
-       if (action == GS_PLUGIN_ACTION_SET_RATING)
-               return "set-rating";
        if (action == GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD)
                return "upgrade-download";
        if (action == GS_PLUGIN_ACTION_UPGRADE_TRIGGER)
@@ -1827,8 +1823,6 @@ gs_plugin_action_from_string (const gchar *action)
                return GS_PLUGIN_ACTION_REMOVE;
        if (g_strcmp0 (action, "update") == 0)
                return GS_PLUGIN_ACTION_UPDATE;
-       if (g_strcmp0 (action, "set-rating") == 0)
-               return GS_PLUGIN_ACTION_SET_RATING;
        if (g_strcmp0 (action, "upgrade-download") == 0)
                return GS_PLUGIN_ACTION_UPGRADE_DOWNLOAD;
        if (g_strcmp0 (action, "upgrade-trigger") == 0)