[gnome-software: 3/5] repos: Drop plugin ordering requirements

commit f890a191e3a7ee6e4b225dd123ef3c6a61c5b0bd
Author: Philip Withnall <pwithnall endlessos org>
Date:   Wed Dec 15 16:14:07 2021 +0000

    repos: Drop plugin ordering requirements
    The app IDs are set from construction time, so there’s no need for repos
    refine to happen after packagekit or rpm-ostree refine.
    This fixes a cycle in plugin construction introduced when merging the
    packagekit-refine-repos plugin into packagekit.
    Ultimately it would be nice to be able to get rid of the repos plugin,
    and instead have the packagekit and rpm-ostree plugins set the
    appropriate data on their apps and repos themselves. Doing it in a
    separate plugin leads to ordering problems, increased latency, and
    problems with keeping data in sync between the plugins, system, apps and
    repo objects.
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    Helps: #1472

 plugins/repos/gs-plugin-repos.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/plugins/repos/gs-plugin-repos.c b/plugins/repos/gs-plugin-repos.c
index 2188b026e..e119eb8ea 100644
--- a/plugins/repos/gs-plugin-repos.c
+++ b/plugins/repos/gs-plugin-repos.c
@@ -69,10 +69,6 @@ gs_plugin_repos_init (GsPluginRepos *self)
                gs_plugin_set_enabled (plugin, FALSE);
-       /* need application IDs */
-       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "packagekit");
-       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "rpm-ostree");
 static void

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]