[gnome-software: 67/72] gs-plugin-job-refine: Drop previous_list handling

[Philip Withnall <pwithnall src gnome org>]

commit 456b4da5b0e93ec2cff34a9e06d84112220899cb
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Dec 6 14:26:05 2021 +0000

    gs-plugin-job-refine: Drop previous_list handling
    
    It was unused and complicating the code.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 lib/gs-plugin-job-refine.c | 18 ------------------
 1 file changed, 18 deletions(-)
---
diff --git a/lib/gs-plugin-job-refine.c b/lib/gs-plugin-job-refine.c
index fbc2a39f1..c022b08e5 100644
--- a/lib/gs-plugin-job-refine.c
+++ b/lib/gs-plugin-job-refine.c
@@ -244,13 +244,6 @@ run_refine_internal (GsPluginJobRefine  *self,
                      GCancellable       *cancellable,
                      GError            **error)
 {
-       g_autoptr(GsAppList) previous_list = NULL;
-
-       if (list != gs_plugin_job_get_list (GS_PLUGIN_JOB (self))) {
-               previous_list = g_object_ref (gs_plugin_job_get_list (GS_PLUGIN_JOB (self)));
-               gs_plugin_job_set_list (GS_PLUGIN_JOB (self), list);
-       }
-
        /* try to adopt each application with a plugin */
        gs_plugin_loader_run_adopt (plugin_loader, list);
 
@@ -258,8 +251,6 @@ run_refine_internal (GsPluginJobRefine  *self,
        if (!run_refine_filter (self, plugin_loader, list,
                                GS_PLUGIN_REFINE_FLAGS_NONE,
                                cancellable, error)) {
-               if (previous_list != NULL)
-                       gs_plugin_job_set_list (GS_PLUGIN_JOB (self), previous_list);
                return FALSE;
        }
 
@@ -298,8 +289,6 @@ run_refine_internal (GsPluginJobRefine  *self,
                        if (!run_refine_internal (self, plugin_loader,
                                                  addons_list, cancellable,
                                                  error)) {
-                               if (previous_list != NULL)
-                                       gs_plugin_job_set_list (GS_PLUGIN_JOB (self), previous_list);
                                return FALSE;
                        }
                }
@@ -320,8 +309,6 @@ run_refine_internal (GsPluginJobRefine  *self,
                        if (!run_refine_internal (self, plugin_loader,
                                                  list2, cancellable,
                                                  error)) {
-                               if (previous_list != NULL)
-                                       gs_plugin_job_set_list (GS_PLUGIN_JOB (self), previous_list);
                                return FALSE;
                        }
                }
@@ -349,16 +336,11 @@ run_refine_internal (GsPluginJobRefine  *self,
                        if (!run_refine_internal (self, plugin_loader,
                                                  related_list, cancellable,
                                                  error)) {
-                               if (previous_list != NULL)
-                                       gs_plugin_job_set_list (GS_PLUGIN_JOB (self), previous_list);
                                return FALSE;
                        }
                }
        }
 
-       if (previous_list != NULL)
-               gs_plugin_job_set_list (GS_PLUGIN_JOB (self), previous_list);
-
        /* success */
        return TRUE;
 }