[gtk/wip/baedert/for-master] gl: Imply that node_supports_transforms() means 2D transforms

[Timm Bäder <baedert src gnome org>]

commit 2561d307d26951c2829e70cca9d899aa4cbbdd2d
Author: Timm Bäder <mail baedert org>
Date:   Fri Dec 10 20:07:39 2021 +0100

    gl: Imply that node_supports_transforms() means 2D transforms
    
    Fixes #4501

 gsk/gl/gskglrenderjob.c                       |  12 ++++++++----
 testsuite/gsk/compare/linear-gradient-3d.node |  13 +++++++++++++
 testsuite/gsk/compare/linear-gradient-3d.png  | Bin 0 -> 151 bytes
 testsuite/gsk/meson.build                     |   8 ++++----
 4 files changed, 25 insertions(+), 8 deletions(-)
---
diff --git a/gsk/gl/gskglrenderjob.c b/gsk/gl/gskglrenderjob.c
index 1862191118..098365b844 100644
--- a/gsk/gl/gskglrenderjob.c
+++ b/gsk/gl/gskglrenderjob.c
@@ -1991,6 +1991,9 @@ gsk_gl_render_job_visit_transform_node (GskGLRenderJob      *job,
   const GskTransformCategory category = gsk_transform_get_category (transform);
   const GskRenderNode *child = gsk_transform_node_get_child (node);
 
+  g_message ("huh: %d (%s)", category,
+             gsk_transform_to_string (transform)
+             );
   switch (category)
     {
     case GSK_TRANSFORM_CATEGORY_IDENTITY:
@@ -2017,16 +2020,17 @@ gsk_gl_render_job_visit_transform_node (GskGLRenderJob      *job,
     break;
 
     case GSK_TRANSFORM_CATEGORY_2D:
-    case GSK_TRANSFORM_CATEGORY_3D:
-    case GSK_TRANSFORM_CATEGORY_ANY:
-    case GSK_TRANSFORM_CATEGORY_UNKNOWN:
       if (node_supports_transform (child))
         {
           gsk_gl_render_job_push_modelview (job, transform);
           gsk_gl_render_job_visit_node (job, child);
           gsk_gl_render_job_pop_modelview (job);
+          return;
         }
-      else
+      G_GNUC_FALLTHROUGH;
+    case GSK_TRANSFORM_CATEGORY_3D:
+    case GSK_TRANSFORM_CATEGORY_ANY:
+    case GSK_TRANSFORM_CATEGORY_UNKNOWN:
         {
           GskGLRenderOffscreen offscreen = {0};
           float sx = 1, sy  = 1;
diff --git a/testsuite/gsk/compare/linear-gradient-3d.node b/testsuite/gsk/compare/linear-gradient-3d.node
new file mode 100644
index 0000000000..b3ba197779
--- /dev/null
+++ b/testsuite/gsk/compare/linear-gradient-3d.node
@@ -0,0 +1,13 @@
+clip {
+  clip: 0 -25 50 50;
+  child: transform {
+    transform: perspective(100) rotateY(45);
+    child: linear-gradient {
+        bounds: 0 -100 200 200;
+        start: 0 -100;
+        end: 0 100;
+        stops: 0.5 red,
+         0.5 lime;
+   }
+ }
+}
diff --git a/testsuite/gsk/compare/linear-gradient-3d.png b/testsuite/gsk/compare/linear-gradient-3d.png
new file mode 100644
index 0000000000..2ac3fd1e44
Binary files /dev/null and b/testsuite/gsk/compare/linear-gradient-3d.png differ
diff --git a/testsuite/gsk/meson.build b/testsuite/gsk/meson.build
index 23821da279..71e18f824d 100644
--- a/testsuite/gsk/meson.build
+++ b/testsuite/gsk/meson.build
@@ -93,10 +93,10 @@ informative_render_tests = [
 ]
 
 renderers = [
-  # name      exclude term
-  [ 'gl', ''    ],
-  [ 'broadway',  '-3d' ],
-  [ 'cairo',  '-3d' ],
+  # name          exclude term
+  [ 'gl', ''           ],
+  [ 'broadway',   '-3d' ],
+  [ 'cairo',      '-3d' ],
 ]
 
 foreach renderer : renderers