[seahorse] sidebar: Don't try to invoke parent's popup menu
- From: Niels De Graef <nielsdg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [seahorse] sidebar: Don't try to invoke parent's popup menu
- Date: Sun, 5 Dec 2021 18:51:56 +0000 (UTC)
commit 7c15af02c8906d81217a1b32af08c7638df5d6a4
Author: Guido Günther <agx sigxcpu org>
Date: Mon Nov 22 16:19:10 2021 +0100
sidebar: Don't try to invoke parent's popup menu
This fixes a crash when hitting the menu key and displays the
menu as expected. Otherwise it crashes like
(gdb) bt
#0 0x0000000000000000 in ()
#1 0x0000556b8bfacc93 in seahorse_sidebar_real_popup_menu (base=0x556b8c768240 [SeahorseSidebar]) at
../src/sidebar.vala:203
#4 0x00007f2a045594a9 in <emit signal ??? on instance 0x556b8c768240 [SeahorseSidebar]>
(node=<optimized out>, detail=0, instance=0x556b8c768240, emission_return=0x7ffc1b838a20,
instance_and_params=0x556b8cc715c0) at ../../../gobject/gsignal.c:3781
#2 0x00007f2a03f11fd2 in _gtk_marshal_BOOLEAN__VOID
(closure=0x556b8c3c7e50, return_value=0x7ffc1b838930, n_param_values=<optimized out>,
param_values=<optimized out>, invocation_hint=<optimized out>, marshal_data=<optimized out>) at
gtkmarshalers.c:2110
#3 0x00007f2a045476cf in g_closure_invoke
(closure=closure@entry=0x556b8c3c7e50, return_value=return_value@entry=0x7ffc1b838930,
n_param_values=1, param_values=param_values@entry=0x556b8cc715c0,
invocation_hint=invocation_hint@entry=0x7ffc1b838910) at ../../../gobject/gclosure.c:830
#5 0x00007f2a03c4546f in gtk_binding_entry_activate (entry=0x556b8c3a4bc0,
object=object@entry=0x556b8c768240 [SeahorseSidebar]) at ../../../../gtk/gtkbindings.c:646
#6 0x00007f2a03c45928 in binding_activate
src/sidebar.vala | 3 ---
1 file changed, 3 deletions(-)
---
diff --git a/src/sidebar.vala b/src/sidebar.vala
index b991d006..5bdda3bb 100644
--- a/src/sidebar.vala
+++ b/src/sidebar.vala
@@ -200,9 +200,6 @@ public class Seahorse.Sidebar : Gtk.ListBox {
}
public override bool popup_menu() {
- if (base.popup_menu())
- return true;
-
var row = get_selected_row() as SidebarItem;
if (row == null)
return false;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]