[gegl] newsprint: remove erronous double-description to fix leak



commit 90e3f532ece1f849c329445ac5ad31b4e7345d2a
Author: Andrzej Hunt <andrzej ahunt org>
Date:   Sat Aug 21 17:37:50 2021 +0200

    newsprint: remove erronous double-description to fix leak
    
    description() is defined as:
      pspec->_blurb = g_strdup (blurb);
    
    Using description() twice for a given property will result in the first
    description being lost and leaked - we therefore remove one description
    to both fix the leak and ensure that the property is using the right
    description.
    
    The second description looks like it was copied from the "Black angle"
    declaration below, and has existed since "Black period" was first added in:
      5113e8e3b (newsprint: add custom period to each colorant, 2019-07-17)

 operations/common/newsprint.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/operations/common/newsprint.c b/operations/common/newsprint.c
index a4a16f710..d641cafde 100644
--- a/operations/common/newsprint.c
+++ b/operations/common/newsprint.c
@@ -139,7 +139,6 @@ property_enum (pattern, _("Black pattern"),
 property_double (period, _("Black period"), 12.0)
                  value_range (0.0, 200.0)
                  description (_("The number of pixels across one repetition of a base pattern at base 
resolution."))
-                 description (_("Angle offset for patterns"))
                  ui_meta ("visible", "color-model {white-on-black, black-on-white, cmyk}")
                  ui_meta ("label", "[color-model {white-on-black,"
                                    "              black-on-white} : bw-label,"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]