[gnome-shell-extensions/wip/rstrode/heads-up-display: 47/62] apps-menu: Add missing chain-up




commit a084c05551bdfdfbe95c14eaf1ca9289e36d122f
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Jun 27 03:57:53 2019 +0200

    apps-menu: Add missing chain-up
    
    PanelMenu.Button is a bit weird in that it also "contains" its parent
    actor. That container is supposed to be destroyed with the button, but
    as we currently don't chain up to the parent class' _onDestroy(), we
    leave behind an empty container every time the extension is disabled.
    
    Fix this by adding the missing chain-up.
    
    https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/75

 extensions/apps-menu/extension.js | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/extensions/apps-menu/extension.js b/extensions/apps-menu/extension.js
index 3dbe43f..1de00df 100644
--- a/extensions/apps-menu/extension.js
+++ b/extensions/apps-menu/extension.js
@@ -435,6 +435,8 @@ class ApplicationsButton extends PanelMenu.Button {
     }
 
     _onDestroy() {
+        super._onDestroy();
+
         Main.overview.disconnect(this._showingId);
         Main.overview.disconnect(this._hidingId);
         appSys.disconnect(this._installedChangedId);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]