[gnome-shell/wip/rstrode/login-screen-extensions: 115/134] workspacesView: Don't set up MetaLater when unparented




commit dc720c60e209a7a903e9d01c90c5cff7ee634d61
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Oct 23 23:44:48 2020 +0200

    workspacesView: Don't set up MetaLater when unparented
    
    We already do the check in the later handler, but if we got
    unparented because the actor is destroyed, then the call to
    get_parent() itself will trigger a (harmless but annoying)
    warning.

 js/ui/workspacesView.js | 3 +++
 1 file changed, 3 insertions(+)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 3e9d776553..8ec610ad58 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -721,6 +721,9 @@ var WorkspacesDisplay = class {
             oldParent.disconnect(this._notifyOpacityId);
         this._notifyOpacityId = 0;
 
+        if (!this.actor.get_parent())
+            return;
+
         Meta.later_add(Meta.LaterType.BEFORE_REDRAW, () => {
             let newParent = this.actor.get_parent();
             if (!newParent)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]