[gnome-shell/wip/rstrode/login-screen-extensions: 105/134] popupMenu: Handle keypress if numlock is enabled




commit 152f03dbf3c02fd9cbfb9fae393d38cba0b4e451
Author: Olivier Fourdan <ofourdan redhat com>
Date:   Tue Jul 21 16:33:04 2020 +0200

    popupMenu: Handle keypress if numlock is enabled
    
    On Wayland, navigating menus with the keyboard would not open drop-down
    menus when NumLock is enabled.
    
    That's old issue (gnome-shell#550) that was not completely fixed with
    commit 88556226 because the lock mask needs to be filtered out in
    _onKeyPress() as well.
    
    Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/550

 js/ui/popupMenu.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index 44818533ab..badde35bdc 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -800,9 +800,10 @@ var PopupMenu = class extends PopupMenuBase {
 
         let state = event.get_state();
 
-        // if user has a modifier down (except capslock)
+        // if user has a modifier down (except capslock and numlock)
         // then don't handle the key press here
         state &= ~Clutter.ModifierType.LOCK_MASK;
+        state &= ~Clutter.ModifierType.MOD2_MASK;
         state &= Clutter.ModifierType.MODIFIER_MASK;
 
         if (state)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]