[gnome-shell/wip/rstrode/login-screen-extensions: 20/134] shellEntry: Make signal id variable private




commit 0d451d9ce1dc381a511a8b1a6daf36f3b61719f8
Author: Jonas Dreßler <verdre v0yd nl>
Date:   Thu Jan 23 22:37:06 2020 +0100

    shellEntry: Make signal id variable private
    
    Signal connection IDs should be private variables, so make this one
    private.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/952

 js/ui/shellEntry.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js
index c1738c4064..cd7c9a6c88 100644
--- a/js/ui/shellEntry.js
+++ b/js/ui/shellEntry.js
@@ -183,19 +183,19 @@ class CapsLockWarning extends St.Label {
 
         this.connect('notify::mapped', () => {
             if (this.is_mapped()) {
-                this.stateChangedId = this._keymap.connect('state-changed',
+                this._stateChangedId = this._keymap.connect('state-changed',
                     this._updateCapsLockWarningOpacity.bind(this));
             } else {
-                this._keymap.disconnect(this.stateChangedId);
-                this.stateChangedId = 0;
+                this._keymap.disconnect(this._stateChangedId);
+                this._stateChangedId = 0;
             }
 
             this._updateCapsLockWarningOpacity();
         });
 
         this.connect('destroy', () => {
-            if (this.stateChangedId > 0)
-                this._keymap.disconnect(this.stateChangedId);
+            if (this._stateChangedId > 0)
+                this._keymap.disconnect(this._stateChangedId);
         });
 
         this.clutter_text.ellipsize = Pango.EllipsizeMode.NONE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]