[gtk/matthiasc/for-master] Revert "imwayland: Tweak preedit text"
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/matthiasc/for-master] Revert "imwayland: Tweak preedit text"
- Date: Tue, 24 Aug 2021 16:07:09 +0000 (UTC)
commit e23c6f4f47d7b1faa6b658f308a2aa0b30797036
Author: Matthias Clasen <mclasen redhat com>
Date: Tue Aug 24 12:02:31 2021 -0400
Revert "imwayland: Tweak preedit text"
This reverts commit d84a028455cadbf146e4cd234f57dc1df2e69cd6.
IBus uses the same character now.
Fixes: #4123
gtk/gtkimcontextwayland.c | 42 ++++--------------------------------------
1 file changed, 4 insertions(+), 38 deletions(-)
---
diff --git a/gtk/gtkimcontextwayland.c b/gtk/gtkimcontextwayland.c
index 10defeaf1a..9f4df8954b 100644
--- a/gtk/gtkimcontextwayland.c
+++ b/gtk/gtkimcontextwayland.c
@@ -571,38 +571,6 @@ gtk_im_context_wayland_set_client_widget (GtkIMContext *context,
}
}
-/* We want a unified experience between GtkIMContextSimple and IBus / Wayland
- * when it comes to Compose sequences. IBus initial implementation of preedit
- * for Compose sequences shows U+2384, which has been described as 'distracting'.
- * This function tries to detect this case, and tweaks the text to match what
- * GtkIMContextSimple produces.
- */
-static char *
-tweak_preedit (const char *text)
-{
- GString *s;
- guint len;
-
- s = g_string_new ("");
-
- len = g_utf8_strlen (text, -1);
-
- for (const char *p = text; *p; p = g_utf8_next_char (p))
- {
- gunichar ch = g_utf8_get_char (p);
-
- if (ch == 0x2384)
- {
- if (len == 1 || p > text)
- g_string_append (s, "ยท");
- }
- else
- g_string_append_unichar (s, ch);
- }
-
- return g_string_free (s, FALSE);
-}
-
static void
gtk_im_context_wayland_get_preedit_string (GtkIMContext *context,
char **str,
@@ -610,7 +578,7 @@ gtk_im_context_wayland_get_preedit_string (GtkIMContext *context,
int *cursor_pos)
{
GtkIMContextWayland *context_wayland = GTK_IM_CONTEXT_WAYLAND (context);
- char *preedit_str;
+ const char *preedit_str;
if (attrs)
*attrs = NULL;
@@ -629,12 +597,14 @@ gtk_im_context_wayland_get_preedit_string (GtkIMContext *context,
}
preedit_str =
- tweak_preedit (context_wayland->current_preedit.text ? context_wayland->current_preedit.text : "");
+ context_wayland->current_preedit.text ? context_wayland->current_preedit.text : "";
if (cursor_pos)
*cursor_pos = g_utf8_strlen (preedit_str,
context_wayland->current_preedit.cursor_begin);
+ if (str)
+ *str = g_strdup (preedit_str);
if (attrs)
{
PangoAttribute *attr;
@@ -664,10 +634,6 @@ gtk_im_context_wayland_get_preedit_string (GtkIMContext *context,
pango_attr_list_insert (*attrs, cursor);
}
}
- if (str)
- *str = preedit_str;
- else
- g_free (preedit_str);
}
static gboolean
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]