[pango/compiler-warnings: 1/6] tests: Silence compiler warnings




commit e2c501ade21727eb0bf38159a5bd00f94491d265
Author: Matthias Clasen <mclasen redhat com>
Date:   Sun Aug 22 02:01:33 2021 -0400

    tests: Silence compiler warnings

 tests/test-font.c          |  2 +-
 tests/test-itemize.c       |  8 ++++----
 tests/test-shape.c         | 11 ++++++-----
 tests/testattributes.c     |  1 +
 tests/testboundaries_ucd.c |  7 +++++--
 tests/testmisc.c           |  2 +-
 6 files changed, 18 insertions(+), 13 deletions(-)
---
diff --git a/tests/test-font.c b/tests/test-font.c
index f291cec8..1d3290c7 100644
--- a/tests/test-font.c
+++ b/tests/test-font.c
@@ -160,7 +160,7 @@ test_metrics (void)
 static void
 test_extents (void)
 {
-  char *str = "Composer";
+  const char *str = "Composer";
   GList *items;
   PangoItem *item;
   PangoGlyphString *glyphs;
diff --git a/tests/test-itemize.c b/tests/test-itemize.c
index 926eb3ae..185edbd2 100644
--- a/tests/test-itemize.c
+++ b/tests/test-itemize.c
@@ -55,7 +55,7 @@ static gboolean
 affects_itemization (PangoAttribute *attr,
                      gpointer        data)
 {
-  switch (attr->klass->type)
+  switch ((int)attr->klass->type)
     {
     /* These affect font selection */
     case PANGO_ATTR_LANGUAGE:
@@ -72,11 +72,11 @@ affects_itemization (PangoAttribute *attr,
     case PANGO_ATTR_GRAVITY:
     case PANGO_ATTR_GRAVITY_HINT:
     /* These are part of ItemProperties, so need to break runs */
+    case PANGO_ATTR_LETTER_SPACING:
     case PANGO_ATTR_SHAPE:
     case PANGO_ATTR_RISE:
-    case PANGO_ATTR_UNDERLINE:
-    case PANGO_ATTR_STRIKETHROUGH:
-    case PANGO_ATTR_LETTER_SPACING:
+    case PANGO_ATTR_LINE_HEIGHT:
+    case PANGO_ATTR_ABSOLUTE_LINE_HEIGHT:
       return TRUE;
     default:
       return FALSE;
diff --git a/tests/test-shape.c b/tests/test-shape.c
index a04291e4..9ce86834 100644
--- a/tests/test-shape.c
+++ b/tests/test-shape.c
@@ -57,7 +57,7 @@ static gboolean
 affects_itemization (PangoAttribute *attr,
                      gpointer        data)
 {
-  switch (attr->klass->type)
+  switch ((int)attr->klass->type)
     {
     /* These affect font selection */
     case PANGO_ATTR_LANGUAGE:
@@ -74,11 +74,11 @@ affects_itemization (PangoAttribute *attr,
     case PANGO_ATTR_GRAVITY:
     case PANGO_ATTR_GRAVITY_HINT:
     /* These are part of ItemProperties, so need to break runs */
+    case PANGO_ATTR_LETTER_SPACING:
     case PANGO_ATTR_SHAPE:
     case PANGO_ATTR_RISE:
-    case PANGO_ATTR_UNDERLINE:
-    case PANGO_ATTR_STRIKETHROUGH:
-    case PANGO_ATTR_LETTER_SPACING:
+    case PANGO_ATTR_LINE_HEIGHT:
+    case PANGO_ATTR_ABSOLUTE_LINE_HEIGHT:
       return TRUE;
     default:
       return FALSE;
@@ -89,11 +89,12 @@ static gboolean
 affects_break_or_shape (PangoAttribute *attr,
                         gpointer        data)
 {
-  switch (attr->klass->type)
+  switch ((int)attr->klass->type)
     {
     /* Affects breaks */
     case PANGO_ATTR_ALLOW_BREAKS:
     /* Affects shaping */
+    case PANGO_ATTR_INSERT_HYPHENS:
     case PANGO_ATTR_FONT_FEATURES:
     case PANGO_ATTR_SHOW:
       return TRUE;
diff --git a/tests/testattributes.c b/tests/testattributes.c
index 662a6142..ff76a773 100644
--- a/tests/testattributes.c
+++ b/tests/testattributes.c
@@ -166,6 +166,7 @@ test_binding (PangoAttribute *attr)
     case FONT_FEATURES:
       g_assert_as (pango_attribute_as_font_features (attr), attr);
       break;
+    case INVALID:
     default:
       g_assert_not_reached ();
     }
diff --git a/tests/testboundaries_ucd.c b/tests/testboundaries_ucd.c
index 0cd301f7..d9f08a57 100644
--- a/tests/testboundaries_ucd.c
+++ b/tests/testboundaries_ucd.c
@@ -263,6 +263,9 @@ do_test (const gchar *filename,
           case G_IO_STATUS_NORMAL:
             line[terminator_pos] = '\0';
             break;
+
+          default:
+            break;
         }
 
       g_test_message ("Parsing line: %s", line);
@@ -276,7 +279,7 @@ do_test (const gchar *filename,
           if (! attrs_equal (attrs, expected_attrs, num_attrs, bits))
             {
               gchar *str = make_test_string (string, attrs, bits);
-              gchar *comments = strchr (line, '#');
+              char *comments = strchr (line, '#');
               if (comments) /* don't print the # comment in the error message.  print it separately */
                {
                  *comments = '\0';
@@ -284,7 +287,7 @@ do_test (const gchar *filename,
                }
              else
                {
-                 comments = "";
+                 comments = (char *)"";
                }
 
               g_test_message ("%s: line %d failed", filename, i);
diff --git a/tests/testmisc.c b/tests/testmisc.c
index da24388b..60694134 100644
--- a/tests/testmisc.c
+++ b/tests/testmisc.c
@@ -314,7 +314,7 @@ test_get_cursor_crash (void)
   PangoLayout *layout;
   int i;
 
-  char *string = "foo\n\rbar\r\nbaz\n\nqux\n\n..";
+  const char *string = "foo\n\rbar\r\nbaz\n\nqux\n\n..";
 
   context = pango_font_map_create_context (pango_cairo_font_map_get_default ());
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]