[gnome-settings-daemon/wip/hadess/power-notifications-device-types: 3/4] power: Add comment about skipped types in low battery notifications




commit 1616fc6714849468980403d38d2f9f80764c996f
Author: Bastien Nocera <hadess hadess net>
Date:   Thu Aug 19 16:33:34 2021 +0200

    power: Add comment about skipped types in low battery notifications
    
    Those device types that exist in upower (and gnome-bluetooth) don't have
    a user-friendly precise name that we could use to show in the
    notification so fallback to the generic name instead.
    
    eg. a "Wearable" could be a watch, or a number of other devices, but
    end-users don't know what a "wearable" is in Bluetooth parlance.

 plugins/power/gsd-power-manager.c | 7 +++++++
 1 file changed, 7 insertions(+)
---
diff --git a/plugins/power/gsd-power-manager.c b/plugins/power/gsd-power-manager.c
index 11078a00..5a2e1ff7 100644
--- a/plugins/power/gsd-power-manager.c
+++ b/plugins/power/gsd-power-manager.c
@@ -501,6 +501,13 @@ static const struct {
         const char *crit_body;
         const char *crit_body_unk;
 } peripheral_battery_notifications[] = {
+        /* Intentionally skipped types (too uncommon, and name too imprecise):
+         * UP_DEVICE_KIND_MODEM
+         * UP_DEVICE_KIND_NETWORK
+         * UP_DEVICE_KIND_VIDEO
+         * UP_DEVICE_KIND_WEARABLE
+         * UP_DEVICE_KIND_TOY
+         */
         {
                 .kind = UP_DEVICE_KIND_MOUSE,
                 /* TRANSLATORS: notification title, a wireless mouse is low or very low on power */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]