[gnome-shell/gnome-40] search: Exclude hidden results from keynav



commit abc45e952addd439491f93c4c9cefe5eafca9317
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Jul 15 18:48:34 2021 +0200

    search: Exclude hidden results from keynav
    
    Since commit 3fb02843, we no longer skip allocation for
    results that don't fit the width, and give them a 0x0
    allocation instead.
    
    That has the unintended side effect of those children now
    being available to keynav. There are cases where we want
    0-sized actors to be part of the focus chain (e.g. FocusTrap),
    but this isn't one of them, so explicitly exclude 0-sized
    children from keynav.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4470
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1916>
    (cherry picked from commit 20d99c69cb39eb8d0828aca1bfd75e31a626b443)

 js/ui/search.js | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/js/ui/search.js b/js/ui/search.js
index de13d6e014..7300b053e3 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -429,6 +429,7 @@ var GridSearchResultsLayout = GObject.registerClass({
                 childBox.set_size(0, 0);
 
             child.allocate(childBox);
+            child.can_focus = childBox.get_area() > 0;
 
             childBox.x1 += childWidth;
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]