[gjs/mozjs91] README.MSVC.md: More refinements



commit 3760d2f9542204f941d2b72c9c334e8032f6f817
Author: Chun-wei Fan <fanchunwei src gnome org>
Date:   Fri Aug 13 16:55:24 2021 +0800

    README.MSVC.md: More refinements
    
    Remove remaining traces of 'mozmake', and updates for the pkg-config file for
    building with Visual Studio.  Also make some points a bit more clear

 README.MSVC.md | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/README.MSVC.md b/README.MSVC.md
index c705fdf2..9cf51a87 100644
--- a/README.MSVC.md
+++ b/README.MSVC.md
@@ -77,7 +77,7 @@ An explanation of the lines above:
 *  `ac_add_options --host=x86_64-pc-mingw32`: Use this as-is, unless building on a 32-bit compiler (replace 
`x86_64` with `i686`; not recommended)
 *  `ac_add_options --disable-tests`: Save some build time
 *  `ac_add_options --enable-optimize`: Use for release builds of SpiderMonkey.  Use `--disable-optimize` 
instead if building with `--enable-debug`
-*  `ac_add_options --enable-debug`: Include debugging functions.  Use `--disable-debug` instead if building 
with `--enable-optimize`
+*  `ac_add_options --enable-debug`: Include debugging functions, for debug builds.  Use `--disable-debug` 
instead if building with `--enable-optimize`
 *  `ac_add_options --disable-jemalloc`: This is absolutely needed, otherwise GJS will not build and run 
correctly
 *  `ac_add_options --prefix=c:/software.b/mozjs91.bin`: Some installation path, change as needed
 
@@ -111,12 +111,9 @@ instructions, as Rust is being involved here.
 Run `./mach build` to carry out the build, and then `./mach build install` to copy
 the completed build to the directory specified by `ac_add_options --prefix=xxx`.
 
-After the configuration finishes successfully, you may run 'mozmake' and
-'mozmake install' as you would for a standard SpiderMonkey build.  If
-'mozmake install' does not work for you for some reason, the DLLs you 
-need and js.exe (if you did not pass in --disable-js-shell) can be 
-found in $(buildroot)/dist/bin (you need *all* the DLLs, make sure 
-that there is no mozglue.dll, otherwise you will need to redo your 
+If `./mach build install` does not work for you for some reason, the DLLs you 
+need and js.exe can be found in $(buildroot)/dist/bin (you need *all* the DLLs,
+make sure that there is no mozglue.dll, otherwise you will need to redo your 
 build as noted above), and the required headers are found in
 $(buildroot)/dist/include.  Note that for PDB files and .lib files, 
 you will need to search for them in $(buildroot),
@@ -133,7 +130,8 @@ You will need to place the generated mozjs-91.pc pkg-config file into
 $(PREFIX)\lib\pkgconfig and ensure that pkg-config can find it by
 setting PKG_CONFIG_PATH.  Ensure that the 'includedir' and 'libdir'
 in there is correct so that the mozjs-91.pc can be used correctly in
-Visual Studio/clang-cl builds.  You will also need to ensure that the
+Visual Studio/clang-cl builds, and replace the `-isystem` with `-I` if
+building GJS with Visual Studio.  You will also need to ensure that the
 existing GObject-Introspection installation (if used) is on the same
 drive where the GJS sources are (and therefore where the GJS build
 is being carried out).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]