[gnome-software: 1/3] Replace GsFixedSizeBin by HdyClamp




commit 667af0a66ba7fecd2dd33433740f93a61e2b2d0b
Author: Adrien Plazas <kekun plazas laposte net>
Date:   Mon Aug 9 14:10:15 2021 +0200

    Replace GsFixedSizeBin by HdyClamp
    
    They serve more or less the same purpose, so let's use the standard
    widget.

 src/gs-category-page.ui  |  4 +--
 src/gs-details-page.ui   | 69 ++++++++++++++++++++++++++++++------------------
 src/gs-extras-page.ui    |  4 +--
 src/gs-installed-page.ui |  2 +-
 src/gs-moderate-page.ui  |  4 +--
 src/gs-search-page.ui    |  2 +-
 src/gs-updates-page.ui   |  2 +-
 7 files changed, 52 insertions(+), 35 deletions(-)
---
diff --git a/src/gs-category-page.ui b/src/gs-category-page.ui
index 68e06e16c..5e8a8a493 100644
--- a/src/gs-category-page.ui
+++ b/src/gs-category-page.ui
@@ -13,10 +13,10 @@
           <object class="GtkViewport" id="viewport3">
             <property name="visible">True</property>
             <child>
-              <object class="GsFixedSizeBin" id="gs_fixed_bin">
+              <object class="HdyClamp">
                 <property name="visible">True</property>
                 <!-- This is 3*420 plus margins, paddings, CSS borders -->
-                <property name="preferred-width">1338</property>
+                <property name="maximum-size">1338</property>
                 <child>
                   <object class="GtkBox">
                     <property name="visible">True</property>
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 4b017aaef..c95e4c31f 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -70,9 +70,9 @@
                       <class name="details-page"/>
                     </style>
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GtkBox" id="box_details_header">
                             <property name="orientation">horizontal</property>
@@ -340,11 +340,11 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
-                          <object class="GtkBox">
+                          <object class="GtkBox" id="application_details">
                             <property name="visible">True</property>
                             <property name="orientation">vertical</property>
                             <property name="spacing">12</property>
@@ -380,9 +380,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GtkBox" id="box_addons">
                             <property name="visible">True</property>
@@ -435,9 +435,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GsAppContextBar" id="context_bar">
                             <property name="visible">True</property>
@@ -447,9 +447,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GtkListBox" id="list_box_version_history">
                             <property name="visible">True</property>
@@ -499,9 +499,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible" bind-source="label_webapp_warning" bind-property="visible" 
bind-flags="sync-create"/>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GtkLabel" id="label_webapp_warning">
                             <property name="visible">False</property>
@@ -519,9 +519,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_app_repo" 
bind-property="visible" bind-flags="sync-create"/>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GsInfoBar" id="infobar_details_app_repo">
                             <property name="visible">True</property>
@@ -534,9 +534,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_app_norepo" 
bind-property="visible" bind-flags="sync-create"/>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GsInfoBar" id="infobar_details_app_norepo">
                             <property name="visible">True</property>
@@ -549,9 +549,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_package_baseos" 
bind-property="visible" bind-flags="sync-create"/>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GsInfoBar" id="infobar_details_package_baseos">
                             <property name="visible">True</property>
@@ -564,9 +564,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_repo" bind-property="visible" 
bind-flags="sync-create"/>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GsInfoBar" id="infobar_details_repo">
                             <property name="visible">True</property>
@@ -580,11 +580,11 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
-                          <object class="GtkBox">
+                          <object class="GtkBox" id="box_license">
                             <property name="visible">True</property>
                             <property name="homogeneous">True</property>
                             <property name="orientation">horizontal</property>
@@ -807,9 +807,9 @@
                     </child>
 
                     <child>
-                      <object class="GsFixedSizeBin">
+                      <object class="HdyClamp">
                         <property name="visible">True</property>
-                        <property name="preferred-width">860</property>
+                        <property name="maximum-size">860</property>
                         <child>
                           <object class="GtkBox" id="box_reviews">
                             <property name="visible">False</property>
@@ -1007,4 +1007,21 @@
       </object>
     </child>
   </object>
+  <object class="GtkSizeGroup">
+    <property name="mode">horizontal</property>
+    <widgets>
+      <widget name="box_details_header"/>
+      <widget name="application_details"/>
+      <widget name="box_addons"/>
+      <widget name="context_bar"/>
+      <widget name="list_box_version_history"/>
+      <widget name="label_webapp_warning"/>
+      <widget name="infobar_details_app_repo"/>
+      <widget name="infobar_details_app_norepo"/>
+      <widget name="infobar_details_package_baseos"/>
+      <widget name="infobar_details_repo"/>
+      <widget name="box_license"/>
+      <widget name="box_reviews"/>
+    </widgets>
+  </object>
 </interface>
diff --git a/src/gs-extras-page.ui b/src/gs-extras-page.ui
index 7d61be88e..0ade17eb2 100644
--- a/src/gs-extras-page.ui
+++ b/src/gs-extras-page.ui
@@ -46,9 +46,9 @@
             <property name="vscrollbar_policy">automatic</property>
             <property name="shadow_type">none</property>
             <child>
-              <object class="GsFixedSizeBin" id="gs_fixed_bin">
+              <object class="HdyClamp">
                 <property name="visible">True</property>
-                <property name="preferred-width">860</property>
+                <property name="maximum-size">860</property>
                 <child>
                   <object class="GtkBox" id="box_results">
                     <property name="visible">True</property>
diff --git a/src/gs-installed-page.ui b/src/gs-installed-page.ui
index b3357e3ac..e46d0b1bd 100644
--- a/src/gs-installed-page.ui
+++ b/src/gs-installed-page.ui
@@ -40,7 +40,7 @@
                   <class name="list-page"/>
                 </style>
                 <child>
-                  <object class="HdyClamp" id="gs_fixed_bin">
+                  <object class="HdyClamp">
                     <property name="visible">True</property>
                     <child>
                       <object class="GtkBox">
diff --git a/src/gs-moderate-page.ui b/src/gs-moderate-page.ui
index fafe6d436..784018118 100644
--- a/src/gs-moderate-page.ui
+++ b/src/gs-moderate-page.ui
@@ -37,9 +37,9 @@
                 <property name="vexpand">True</property>
                 <property name="shadow_type">none</property>
                 <child>
-                  <object class="GsFixedSizeBin" id="gs_fixed_bin">
+                  <object class="HdyClamp">
                     <property name="visible">True</property>
-                    <property name="preferred-width">860</property>
+                    <property name="maximum-size">860</property>
                     <child>
                       <object class="GtkListBox" id="list_box_install">
                         <property name="visible">True</property>
diff --git a/src/gs-search-page.ui b/src/gs-search-page.ui
index f03c7193b..e0f048242 100644
--- a/src/gs-search-page.ui
+++ b/src/gs-search-page.ui
@@ -53,7 +53,7 @@
               <class name="list-page"/>
             </style>
             <child>
-              <object class="HdyClamp" id="gs_fixed_bin">
+              <object class="HdyClamp">
                 <property name="visible">True</property>
                 <property name="maximum-size">860</property>
                 <property name="tightening-threshold">860</property>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index e5c949f05..993b6ef30 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -130,7 +130,7 @@
                   <class name="list-page"/>
                 </style>
                 <child>
-                  <object class="HdyClamp" id="gs_fixed_bin">
+                  <object class="HdyClamp">
                     <property name="visible">True</property>
                     <child>
                       <object class="GtkBox" id="list_box_updates_box">


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]