[glib/wip/freebsd-thread-pool-free] tests: GThreadPool free-function is not reliably called on FreeBSD yet




commit 2c95eb6e876bf9c7852b298a71989a9bcfc47605
Author: Simon McVittie <smcv collabora com>
Date:   Thu Aug 5 12:46:13 2021 +0100

    tests: GThreadPool free-function is not reliably called on FreeBSD yet
    
    This new feature in 2.69.0 does not appear to be reliable on the FreeBSD
    CI runners. Disable this part of the test while it's investigated,
    so that we can use CI as an acceptance gate for unrelated branches again.
    
    Leave it enabled when run with `-m thorough` so that FreeBSD developers
    can debug the intermittent failure.
    
    Mitigates: https://gitlab.gnome.org/GNOME/glib/-/issues/2456
    Signed-off-by: Simon McVittie <smcv collabora com>

 glib/tests/thread-pool.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
---
diff --git a/glib/tests/thread-pool.c b/glib/tests/thread-pool.c
index 50a72a632..b497b9a00 100644
--- a/glib/tests/thread-pool.c
+++ b/glib/tests/thread-pool.c
@@ -194,6 +194,16 @@ test_thread_pool_full (gconstpointer shared_first)
   g_assert_true (success);
 
   g_thread_pool_free (pool, TRUE, TRUE);
+
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
+  if (!free_func_called && !g_test_thorough ())
+    {
+      g_test_incomplete ("GThreadPool free-function not called - "
+                         "https://gitlab.gnome.org/GNOME/glib/-/issues/2456";);
+      return;
+    }
+#endif
+
   g_assert_true (free_func_called);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]