[gnome-software: 9/18] gs-details-page: Drop the channel label

[Philip Withnall <pwithnall src gnome org>]

commit 44b89bbb4b7f5a6897792966e929f85cec907009
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Jul 26 15:56:29 2021 +0100

    gs-details-page: Drop the channel label
    
    It doesn’t fit in with the new designs:
    https://gitlab.gnome.org/Teams/Design/software-mockups/-/raw/master/adaptive/app-page-adaptive.png.
    
    It will likely have to be re-added when this version of gnome-software
    is updated for snap support again, if it’s still necessary for snaps.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1111

 src/gs-details-page.c  | 14 --------------
 src/gs-details-page.ui | 35 -----------------------------------
 2 files changed, 49 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 668e89add..b57f6ad0f 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -123,8 +123,6 @@ struct _GsDetailsPage
        GtkWidget               *label_details_developer_value;
        GtkWidget               *box_details_developer;
        GtkWidget               *image_details_developer_verified;
-       GtkWidget               *label_details_channel_title;
-       GtkWidget               *label_details_channel_value;
        GtkWidget               *label_details_origin_title;
        GtkWidget               *label_details_origin_value;
        GtkWidget               *label_failed;
@@ -1076,16 +1074,6 @@ gs_details_page_refresh_all (GsDetailsPage *self)
        }
        gtk_widget_set_visible (self->image_details_developer_verified, gs_app_has_quirk (self->app, 
GS_APP_QUIRK_DEVELOPER_VERIFIED));
 
-       /* set channel for snaps */
-       if (gs_app_get_bundle_kind (self->app) == AS_BUNDLE_KIND_SNAP) {
-               gtk_label_set_label (GTK_LABEL (self->label_details_channel_value), gs_app_get_branch 
(self->app));
-               gtk_widget_set_visible (self->label_details_channel_title, TRUE);
-               gtk_widget_set_visible (self->label_details_channel_value, TRUE);
-       } else {
-               gtk_widget_set_visible (self->label_details_channel_title, FALSE);
-               gtk_widget_set_visible (self->label_details_channel_value, FALSE);
-       }
-
        /* set version history */
        version_history = gs_app_get_version_history (self->app);
        if (version_history == NULL || version_history->len == 0) {
@@ -2343,8 +2331,6 @@ gs_details_page_class_init (GsDetailsPageClass *klass)
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_developer_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, box_details_developer);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, image_details_developer_verified);
-       gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_channel_title);
-       gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_channel_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_origin_title);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_origin_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_failed);
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index ad80b04ac..e0dab744c 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -803,41 +803,6 @@
                                 <property name="column_spacing">24</property>
                                 <property name="hexpand">True</property>
                                 <property name="valign">start</property>
-                                <child>
-                                  <object class="GtkLabel" id="label_details_channel_title">
-                                    <property name="visible">True</property>
-                                    <property name="label" translatable="yes">Channel</property>
-                                    <property name="xalign">0</property>
-                                    <property name="yalign">0.5</property>
-                                    <property name="vexpand">True</property>
-                                    <style>
-                                      <class name="dim-label"/>
-                                    </style>
-                                  </object>
-                                  <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">0</property>
-                                  </packing>
-                                </child>
-                                <child>
-                                  <object class="GtkLabel" id="label_details_channel_value">
-                                    <property name="visible">True</property>
-                                    <property name="can_focus">True</property>
-                                    <property name="hexpand">True</property>
-                                    <property name="label">stable</property>
-                                    <property name="selectable">True</property>
-                                    <property name="ellipsize">end</property>
-                                    <property name="xalign">0</property>
-                                    <property name="yalign">0.5</property>
-                                    <accessibility>
-                                      <relation type="labelled-by" target="label_details_channel_title"/>
-                                    </accessibility>
-                                  </object>
-                                  <packing>
-                                    <property name="left_attach">1</property>
-                                    <property name="top_attach">0</property>
-                                  </packing>
-                                </child>
 
                                 <child>
                                   <object class="GtkLabel" id="label_details_origin_title">