[gnome-builder] devhelp: Don't use global shortcut phase for shortcuts



commit ef9766e0b29f341f14d09c2760a734db8a02f3ea
Author: vanadiae <vanadiae35 gmail com>
Date:   Tue Aug 3 17:04:52 2021 +0200

    devhelp: Don't use global shortcut phase for shortcuts
    
    I added them when trying to get the shortcuts working yesterday, but it
    seems like they are of no use here. Even worse, it breaks the shortcuts
    for other editor pages as they take precedence over e.g. the source view
    Ctrl+F, which breaks things. So just remove them :)
    
    Fixes feca93463e63e0cb9eb397e0b5fe4b646879a6a5

 src/plugins/devhelp/gbp-devhelp-page.c   | 10 +++++-----
 src/plugins/devhelp/gbp-devhelp-search.c |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/src/plugins/devhelp/gbp-devhelp-page.c b/src/plugins/devhelp/gbp-devhelp-page.c
index ae32fbaba..998d21e01 100644
--- a/src/plugins/devhelp/gbp-devhelp-page.c
+++ b/src/plugins/devhelp/gbp-devhelp-page.c
@@ -389,26 +389,26 @@ gbp_devhelp_page_init (GbpDevhelpPage *self)
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-view.reveal-search"),
                                               "<Primary>f",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-view.reveal-search"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-view.history-next"),
                                               "<Alt>Right",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-view.history-next"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-view.history-previous"),
                                               "<Alt>Left",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-view.history-previous"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-view.history-next"),
                                               "<Alt>KP_Right",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-view.history-next"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-view.history-previous"),
                                               "<Alt>KP_Left",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-view.history-previous"));
 }
diff --git a/src/plugins/devhelp/gbp-devhelp-search.c b/src/plugins/devhelp/gbp-devhelp-search.c
index fd884ba62..0dd261ad2 100644
--- a/src/plugins/devhelp/gbp-devhelp-search.c
+++ b/src/plugins/devhelp/gbp-devhelp-search.c
@@ -179,17 +179,17 @@ gbp_devhelp_search_init (GbpDevhelpSearch *self)
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-search.close"),
                                               "Escape",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-search.close"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-search.find-next"),
                                               "<Primary>g",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-search.find-next"));
   dzl_shortcut_controller_add_command_action (controller,
                                               I_("org.gnome.builder.devhelp-search.find-previous"),
                                               "<Primary><shift>g",
-                                              DZL_SHORTCUT_PHASE_CAPTURE | DZL_SHORTCUT_PHASE_GLOBAL,
+                                              DZL_SHORTCUT_PHASE_CAPTURE,
                                               I_("devhelp-search.find-previous"));
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]