[gnome-software: 7/15] gs-safety-context-dialog: Add safety context dialogue
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 7/15] gs-safety-context-dialog: Add safety context dialogue
- Date: Tue, 3 Aug 2021 15:19:42 +0000 (UTC)
commit 780bf2ff1263ee1f0858e459f6fd2ac453cdcebe
Author: Philip Withnall <pwithnall endlessos org>
Date: Thu Jul 15 16:31:13 2021 +0100
gs-safety-context-dialog: Add safety context dialogue
This presents information about the safety/trustworthiness of an app to
the user.
A future commit will make it appear when the safety tile in
`GsAppContextBar` is clicked.
Some of the code for working out the safety is copied from the
`GsAppContextBar`. It will be refactored to remove the duplication in a
future commit.
Includes significant work by Adrien Plazas.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
Helps: #1111
po/POTFILES.in | 2 +
src/gnome-software.gresource.xml | 1 +
src/gs-safety-context-dialog.c | 623 +++++++++++++++++++++++++++++++++++++++
src/gs-safety-context-dialog.h | 31 ++
src/gs-safety-context-dialog.ui | 280 ++++++++++++++++++
src/meson.build | 1 +
6 files changed, 938 insertions(+)
---
diff --git a/po/POTFILES.in b/po/POTFILES.in
index c8b5b2a1f..ede3e3290 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -64,6 +64,8 @@ src/gs-review-dialog.ui
src/gs-review-histogram.ui
src/gs-review-row.c
src/gs-review-row.ui
+src/gs-safety-context-dialog.c
+src/gs-safety-context-dialog.ui
src/gs-screenshot-carousel.ui
src/gs-screenshot-image.c
src/gs-search-page.c
diff --git a/src/gnome-software.gresource.xml b/src/gnome-software.gresource.xml
index 5a0c55bc5..52157b29b 100644
--- a/src/gnome-software.gresource.xml
+++ b/src/gnome-software.gresource.xml
@@ -31,6 +31,7 @@
<file preprocess="xml-stripblanks">gs-review-dialog.ui</file>
<file preprocess="xml-stripblanks">gs-review-histogram.ui</file>
<file preprocess="xml-stripblanks">gs-review-row.ui</file>
+ <file preprocess="xml-stripblanks">gs-safety-context-dialog.ui</file>
<file preprocess="xml-stripblanks">gs-screenshot-carousel.ui</file>
<file preprocess="xml-stripblanks">gs-screenshot-image.ui</file>
<file preprocess="xml-stripblanks">gs-search-page.ui</file>
diff --git a/src/gs-safety-context-dialog.c b/src/gs-safety-context-dialog.c
new file mode 100644
index 000000000..7ad7f983d
--- /dev/null
+++ b/src/gs-safety-context-dialog.c
@@ -0,0 +1,623 @@
+/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*-
+ * vi:set noexpandtab tabstop=8 shiftwidth=8:
+ *
+ * Copyright (C) 2021 Endless OS Foundation LLC
+ *
+ * Author: Philip Withnall <pwithnall endlessos org>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+/**
+ * SECTION:gs-safety-context-dialog
+ * @short_description: A dialog showing safety information about an app
+ *
+ * #GsSafetyContextDialog is a dialog which shows detailed information about
+ * how safe or trustworthy an app is. This information is derived from the
+ * permissions the app requires to run, its runtime, origin, and various other
+ * sources.
+ *
+ * It is designed to show a more detailed view of the information which the
+ * app’s safety tile in #GsAppContextBar is derived from.
+ *
+ * The widget has no special appearance if the app is unset, so callers will
+ * typically want to hide the dialog in that case.
+ *
+ * Since: 41
+ */
+
+#include "config.h"
+
+#include <glib.h>
+#include <glib-object.h>
+#include <glib/gi18n.h>
+#include <gtk/gtk.h>
+#include <handy.h>
+#include <locale.h>
+
+#include "gs-app.h"
+#include "gs-common.h"
+#include "gs-context-dialog-row.h"
+#include "gs-safety-context-dialog.h"
+
+struct _GsSafetyContextDialog
+{
+ HdyWindow parent_instance;
+
+ GsApp *app; /* (nullable) (owned) */
+ gulong app_notify_handler_permissions;
+ gulong app_notify_handler_name;
+ gulong app_notify_handler_quirk;
+ gulong app_notify_handler_license;
+ gulong app_notify_handler_related;
+
+ GtkImage *icon;
+ GtkWidget *lozenge;
+ GtkLabel *title;
+ GtkListBox *permissions_list;
+
+ GtkLabel *license_label;
+ GBinding *license_label_binding; /* (owned) (nullable) */
+ GtkLabel *source_label;
+ GBinding *source_label_binding; /* (owned) (nullable) */
+ GtkLabel *sdk_label;
+ GtkWidget *sdk_row;
+};
+
+G_DEFINE_TYPE (GsSafetyContextDialog, gs_safety_context_dialog, HDY_TYPE_WINDOW)
+
+typedef enum {
+ PROP_APP = 1,
+} GsSafetyContextDialogProperty;
+
+static GParamSpec *obj_props[PROP_APP + 1] = { NULL, };
+
+/* @icon_name_without_permission, @title_without_permission and
+ * @description_without_permission are all nullable. If they are NULL, no row
+ * is added if @has_permission is false. */
+static void
+add_permission_row (GtkListBox *list_box,
+ GsContextDialogRowImportance *chosen_rating,
+ gboolean has_permission,
+ GsContextDialogRowImportance item_rating,
+ const gchar *icon_name_with_permission,
+ const gchar *title_with_permission,
+ const gchar *description_with_permission,
+ const gchar *icon_name_without_permission,
+ const gchar *title_without_permission,
+ const gchar *description_without_permission)
+{
+ GtkListBoxRow *row;
+
+ if (has_permission && item_rating > *chosen_rating)
+ *chosen_rating = item_rating;
+
+ if (!has_permission && title_without_permission == NULL)
+ return;
+
+ row = gs_context_dialog_row_new (has_permission ? icon_name_with_permission :
icon_name_without_permission,
+ has_permission ? item_rating :
GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT,
+ has_permission ? title_with_permission : title_without_permission,
+ has_permission ? description_with_permission :
description_without_permission);
+ gtk_list_box_insert (list_box, GTK_WIDGET (row), -1);
+}
+
+static void
+update_permissions_list (GsSafetyContextDialog *self)
+{
+ const gchar *icon_name, *css_class;
+ g_autofree gchar *title = NULL;
+ g_autoptr(GPtrArray) descriptions = g_ptr_array_new_with_free_func (NULL);
+ g_autofree gchar *description = NULL;
+ GsAppPermissions permissions;
+ GtkStyleContext *context;
+ GsContextDialogRowImportance chosen_rating;
+
+ /* Treat everything as safe to begin with, and downgrade its safety
+ * based on app properties. */
+ chosen_rating = GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT;
+
+ gs_container_remove_all (GTK_CONTAINER (self->permissions_list));
+
+ /* UI state is undefined if app is not set. */
+ if (self->app == NULL)
+ return;
+
+ permissions = gs_app_get_permissions (self->app);
+
+ /* Handle unknown permissions. */
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions == GS_APP_PERMISSIONS_UNKNOWN),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "dialog-question-symbolic",
+ _("Unknown Permissions"),
+ _("The permissions needed by this app aren’t known"),
+ NULL, NULL, NULL);
+
+ if (permissions != GS_APP_PERMISSIONS_UNKNOWN) {
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_NONE) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT,
+ "folder-documents-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("No Permissions"),
+ _("App is fully sandboxed"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_NETWORK) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "network-wireless-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Network Access"),
+ _("Can access the internet"),
+ "network-wireless-disabled-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("No Network Access"),
+ _("Cannot access the internet"));
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_SYSTEM_BUS) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "emblem-system-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Uses System Services"),
+ _("Can request data from system services"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_SESSION_BUS) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "emblem-system-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Uses Session Services"),
+ _("Can request data from session services"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_DEVICES) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "camera-photo-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Device Access"),
+ _("Can access devices such as webcams or gaming controllers"),
+ "camera-disabled-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("No Device Access"),
+ _("Cannot access devices such as webcams or gaming controllers"));
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_X11) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "desktop-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Legacy Windowing System"),
+ _("Uses a legacy windowing system"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_ESCAPE_SANDBOX) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "dialog-warning-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Arbitrary Permissions"),
+ _("Can acquire arbitrary permissions"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_SETTINGS) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "preferences-system-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("User Settings"),
+ _("Can access and change user settings"),
+ NULL, NULL, NULL);
+
+ /* File system permissions are a bit more complex, since there are
+ * varying scopes of what’s readable/writable, and a difference between
+ * read-only and writable access. */
+ add_permission_row (self->permissions_list, &chosen_rating,
+ (permissions & GS_APP_PERMISSIONS_FILESYSTEM_FULL) != 0,
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "folder-documents-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Full File System Read/Write Access"),
+ _("Can read and write all data on the file system"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ ((permissions & GS_APP_PERMISSIONS_HOME_FULL) != 0 &&
+ !(permissions & GS_APP_PERMISSIONS_FILESYSTEM_FULL)),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "user-home-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Home Read/Write Access"),
+ _("Can read and write all data in your home directory"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ ((permissions & GS_APP_PERMISSIONS_FILESYSTEM_READ) != 0 &&
+ !(permissions & GS_APP_PERMISSIONS_FILESYSTEM_FULL)),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "folder-documents-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Full File System Read Access"),
+ _("Can read all data on the file system"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ ((permissions & GS_APP_PERMISSIONS_HOME_READ) != 0 &&
+ !(permissions & (GS_APP_PERMISSIONS_FILESYSTEM_FULL |
+ GS_APP_PERMISSIONS_FILESYSTEM_READ))),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT,
+ "user-home-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Home Read Access"),
+ _("Can read all data in your home directory"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ ((permissions & GS_APP_PERMISSIONS_DOWNLOADS_FULL) != 0 &&
+ !(permissions & (GS_APP_PERMISSIONS_FILESYSTEM_FULL |
+ GS_APP_PERMISSIONS_HOME_FULL))),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "folder-download-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Downloads Read/Write Access"),
+ _("Can read and write all data in your downloads directory"),
+ NULL, NULL, NULL);
+ add_permission_row (self->permissions_list, &chosen_rating,
+ ((permissions & GS_APP_PERMISSIONS_DOWNLOADS_READ) != 0 &&
+ !(permissions & (GS_APP_PERMISSIONS_FILESYSTEM_FULL |
+ GS_APP_PERMISSIONS_FILESYSTEM_READ |
+ GS_APP_PERMISSIONS_HOME_FULL |
+ GS_APP_PERMISSIONS_HOME_READ))),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "folder-download-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("Downloads Read Access"),
+ _("Can read all data in your downloads directory"),
+ NULL, NULL, NULL);
+
+ add_permission_row (self->permissions_list, &chosen_rating,
+ !(permissions & (GS_APP_PERMISSIONS_FILESYSTEM_FULL |
+ GS_APP_PERMISSIONS_FILESYSTEM_READ |
+ GS_APP_PERMISSIONS_HOME_FULL |
+ GS_APP_PERMISSIONS_HOME_READ |
+ GS_APP_PERMISSIONS_DOWNLOADS_FULL |
+ GS_APP_PERMISSIONS_DOWNLOADS_READ)),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT,
+ "folder-documents-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak)
which an app requests from the user. */
+ _("No File System Access"),
+ _("Cannot access the file system at all"),
+ NULL, NULL, NULL);
+ }
+
+ /* Is the code FOSS and hence inspectable? This doesn’t distinguish
+ * between closed source and open-source-but-not-FOSS software, even
+ * though the code of the latter is technically publicly auditable. This
+ * is because I don’t want to get into the business of maintaining lists
+ * of ‘auditable’ source code licenses. */
+ add_permission_row (self->permissions_list, &chosen_rating,
+ !gs_app_get_license_is_free (self->app),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING,
+ "dialog-warning-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak) which an
app requests from the user. */
+ _("Proprietary Code"),
+ _("The source code is not public, so it cannot be independently audited and might
be unsafe"),
+ "test-pass-symbolic",
+ /* Translators: This refers to permissions (for example, from flatpak) which an
app requests from the user. */
+ _("Auditable Code"),
+ _("The source code is public and can be independently audited, which makes the
app more likely to be safe"));
+
+ /* Does the app come from official sources, such as this distro’s main
+ * repos? */
+ add_permission_row (self->permissions_list, &chosen_rating,
+ gs_app_has_quirk (self->app, GS_APP_QUIRK_PROVENANCE),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT,
+ "test-pass-symbolic",
+ /* Translators: This indicates an app comes from the distribution’s main
repositories, so can be trusted.
+ * It’s used in a context tile, so should be short. */
+ _("App comes from a trusted source"),
+ _("Your distribution has verified that this app can be trusted"),
+ NULL, NULL, NULL);
+
+ add_permission_row (self->permissions_list, &chosen_rating,
+ gs_app_has_quirk (self->app, GS_APP_QUIRK_DEVELOPER_VERIFIED),
+ GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT,
+ "test-pass-symbolic",
+ /* Translators: This indicates an app was written and released by a developer who
has been verified.
+ * It’s used in a context tile, so should be short. */
+ _("App developer is verified"),
+ _("The developer of this app has been verified to be who they say they are"),
+ NULL, NULL, NULL);
+
+ /* Update the UI. */
+ switch (chosen_rating) {
+ case GS_CONTEXT_DIALOG_ROW_IMPORTANCE_UNIMPORTANT:
+ icon_name = "safety-symbolic";
+ /* Translators: The app is considered safe to install and run.
+ * The placeholder is the app name. */
+ title = g_strdup_printf (_("%s is Safe"), gs_app_get_name (self->app));
+ css_class = "green";
+ break;
+ case GS_CONTEXT_DIALOG_ROW_IMPORTANCE_WARNING:
+ icon_name = "dialog-question-symbolic";
+ /* Translators: The app is considered potentially unsafe to install and run.
+ * The placeholder is the app name. */
+ title = g_strdup_printf (_("%s is Potentially Unsafe"), gs_app_get_name (self->app));
+ css_class = "yellow";
+ break;
+ case GS_CONTEXT_DIALOG_ROW_IMPORTANCE_IMPORTANT:
+ icon_name = "dialog-warning-symbolic";
+ /* Translators: The app is considered unsafe to install and run.
+ * The placeholder is the app name. */
+ title = g_strdup_printf (_("%s is Unsafe"), gs_app_get_name (self->app));
+ css_class = "red";
+ break;
+ default:
+ g_assert_not_reached ();
+ }
+
+ gtk_image_set_from_icon_name (GTK_IMAGE (self->icon), icon_name, GTK_ICON_SIZE_LARGE_TOOLBAR);
+ gtk_label_set_text (self->title, title);
+
+ context = gtk_widget_get_style_context (self->lozenge);
+
+ gtk_style_context_remove_class (context, "green");
+ gtk_style_context_remove_class (context, "yellow");
+ gtk_style_context_remove_class (context, "red");
+
+ gtk_style_context_add_class (context, css_class);
+}
+
+static void
+app_notify_cb (GObject *obj,
+ GParamSpec *pspec,
+ gpointer user_data)
+{
+ GsSafetyContextDialog *self = GS_SAFETY_CONTEXT_DIALOG (user_data);
+
+ update_permissions_list (self);
+}
+
+static void
+update_sdk (GsSafetyContextDialog *self)
+{
+ GsApp *runtime;
+
+ /* UI state is undefined if app is not set. */
+ if (self->app == NULL)
+ return;
+
+ runtime = gs_app_get_runtime (self->app);
+
+ if (runtime != NULL) {
+ g_autofree gchar *label = NULL;
+ const gchar *version = gs_app_get_version_ui (runtime);
+
+ if (version != NULL) {
+ /* Translators: The first placeholder is an app runtime
+ * name, the second is its version number. */
+ label = g_strdup_printf (_("%s (%s)"),
+ gs_app_get_name (runtime),
+ version);
+ } else {
+ label = g_strdup (gs_app_get_name (runtime));
+ }
+
+ gtk_label_set_label (self->sdk_label, label);
+ }
+
+ /* Only show the row if a runtime was found. */
+ gtk_widget_set_visible (self->sdk_row, (runtime != NULL));
+}
+
+static void
+app_notify_related_cb (GObject *obj,
+ GParamSpec *pspec,
+ gpointer user_data)
+{
+ GsSafetyContextDialog *self = GS_SAFETY_CONTEXT_DIALOG (user_data);
+
+ update_sdk (self);
+}
+
+static gboolean
+key_press_event_cb (GtkWidget *sender,
+ GdkEvent *event,
+ HdyPreferencesWindow *self)
+{
+ guint keyval;
+ GdkModifierType state;
+ GdkKeymap *keymap;
+ GdkEventKey *key_event = (GdkEventKey *) event;
+
+ gdk_event_get_state (event, &state);
+
+ keymap = gdk_keymap_get_for_display (gtk_widget_get_display (sender));
+
+ gdk_keymap_translate_keyboard_state (keymap,
+ key_event->hardware_keycode,
+ state,
+ key_event->group,
+ &keyval, NULL, NULL, NULL);
+
+ if (keyval == GDK_KEY_Escape) {
+ gtk_window_close (GTK_WINDOW (self));
+
+ return GDK_EVENT_STOP;
+ }
+
+ return GDK_EVENT_PROPAGATE;
+}
+
+static void
+gs_safety_context_dialog_init (GsSafetyContextDialog *self)
+{
+ gtk_widget_init_template (GTK_WIDGET (self));
+}
+
+static void
+gs_safety_context_dialog_get_property (GObject *object,
+ guint prop_id,
+ GValue *value,
+ GParamSpec *pspec)
+{
+ GsSafetyContextDialog *self = GS_SAFETY_CONTEXT_DIALOG (object);
+
+ switch ((GsSafetyContextDialogProperty) prop_id) {
+ case PROP_APP:
+ g_value_set_object (value, gs_safety_context_dialog_get_app (self));
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+ break;
+ }
+}
+
+static void
+gs_safety_context_dialog_set_property (GObject *object,
+ guint prop_id,
+ const GValue *value,
+ GParamSpec *pspec)
+{
+ GsSafetyContextDialog *self = GS_SAFETY_CONTEXT_DIALOG (object);
+
+ switch ((GsSafetyContextDialogProperty) prop_id) {
+ case PROP_APP:
+ gs_safety_context_dialog_set_app (self, g_value_get_object (value));
+ break;
+ default:
+ G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+ break;
+ }
+}
+
+static void
+gs_safety_context_dialog_dispose (GObject *object)
+{
+ GsSafetyContextDialog *self = GS_SAFETY_CONTEXT_DIALOG (object);
+
+ gs_safety_context_dialog_set_app (self, NULL);
+
+ G_OBJECT_CLASS (gs_safety_context_dialog_parent_class)->dispose (object);
+}
+
+static void
+gs_safety_context_dialog_class_init (GsSafetyContextDialogClass *klass)
+{
+ GObjectClass *object_class = G_OBJECT_CLASS (klass);
+ GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
+
+ object_class->get_property = gs_safety_context_dialog_get_property;
+ object_class->set_property = gs_safety_context_dialog_set_property;
+ object_class->dispose = gs_safety_context_dialog_dispose;
+
+ /**
+ * GsSafetyContextDialog:app: (nullable)
+ *
+ * The app to display the safety context details for.
+ *
+ * This may be %NULL; if so, the content of the widget will be
+ * undefined.
+ *
+ * Since: 41
+ */
+ obj_props[PROP_APP] =
+ g_param_spec_object ("app", NULL, NULL,
+ GS_TYPE_APP,
+ G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
+
+ g_object_class_install_properties (object_class, G_N_ELEMENTS (obj_props), obj_props);
+
+ gtk_widget_class_set_template_from_resource (widget_class,
"/org/gnome/Software/gs-safety-context-dialog.ui");
+
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, icon);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, lozenge);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, title);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, permissions_list);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, license_label);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, source_label);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, sdk_label);
+ gtk_widget_class_bind_template_child (widget_class, GsSafetyContextDialog, sdk_row);
+
+ gtk_widget_class_bind_template_callback (widget_class, key_press_event_cb);
+}
+
+/**
+ * gs_safety_context_dialog_new:
+ * @app: (nullable): the app to display safety context information for, or %NULL
+ *
+ * Create a new #GsSafetyContextDialog and set its initial app to @app.
+ *
+ * Returns: (transfer full): a new #GsSafetyContextDialog
+ * Since: 41
+ */
+GsSafetyContextDialog *
+gs_safety_context_dialog_new (GsApp *app)
+{
+ g_return_val_if_fail (app == NULL || GS_IS_APP (app), NULL);
+
+ return g_object_new (GS_TYPE_SAFETY_CONTEXT_DIALOG,
+ "app", app,
+ NULL);
+}
+
+/**
+ * gs_safety_context_dialog_get_app:
+ * @self: a #GsSafetyContextDialog
+ *
+ * Gets the value of #GsSafetyContextDialog:app.
+ *
+ * Returns: (nullable) (transfer none): app whose safety context information is
+ * being displayed, or %NULL if none is set
+ * Since: 41
+ */
+GsApp *
+gs_safety_context_dialog_get_app (GsSafetyContextDialog *self)
+{
+ g_return_val_if_fail (GS_IS_SAFETY_CONTEXT_DIALOG (self), NULL);
+
+ return self->app;
+}
+
+/**
+ * gs_safety_context_dialog_set_app:
+ * @self: a #GsSafetyContextDialog
+ * @app: (nullable) (transfer none): the app to display safety context
+ * information for, or %NULL for none
+ *
+ * Set the value of #GsSafetyContextDialog:app.
+ *
+ * Since: 41
+ */
+void
+gs_safety_context_dialog_set_app (GsSafetyContextDialog *self,
+ GsApp *app)
+{
+ g_return_if_fail (GS_IS_SAFETY_CONTEXT_DIALOG (self));
+ g_return_if_fail (app == NULL || GS_IS_APP (app));
+
+ if (app == self->app)
+ return;
+
+ g_clear_signal_handler (&self->app_notify_handler_permissions, self->app);
+ g_clear_signal_handler (&self->app_notify_handler_name, self->app);
+ g_clear_signal_handler (&self->app_notify_handler_quirk, self->app);
+ g_clear_signal_handler (&self->app_notify_handler_license, self->app);
+ g_clear_signal_handler (&self->app_notify_handler_related, self->app);
+
+ g_clear_object (&self->license_label_binding);
+ g_clear_object (&self->source_label_binding);
+
+ g_set_object (&self->app, app);
+
+ if (self->app != NULL) {
+ self->app_notify_handler_permissions = g_signal_connect (self->app, "notify::permissions",
G_CALLBACK (app_notify_cb), self);
+ self->app_notify_handler_name = g_signal_connect (self->app, "notify::name", G_CALLBACK
(app_notify_cb), self);
+ self->app_notify_handler_quirk = g_signal_connect (self->app, "notify::quirk", G_CALLBACK
(app_notify_cb), self);
+ self->app_notify_handler_license = g_signal_connect (self->app, "notify::license", G_CALLBACK
(app_notify_cb), self);
+
+ self->app_notify_handler_related = g_signal_connect (self->app, "notify::related", G_CALLBACK
(app_notify_related_cb), self);
+
+ self->license_label_binding = g_object_bind_property (self->app, "license",
self->license_label, "label", G_BINDING_SYNC_CREATE);
+ self->source_label_binding = g_object_bind_property (self->app, "origin-ui",
self->source_label, "label", G_BINDING_SYNC_CREATE);
+ }
+
+ /* Update the UI. */
+ update_permissions_list (self);
+ update_sdk (self);
+
+ g_object_notify_by_pspec (G_OBJECT (self), obj_props[PROP_APP]);
+}
diff --git a/src/gs-safety-context-dialog.h b/src/gs-safety-context-dialog.h
new file mode 100644
index 000000000..85e9e7322
--- /dev/null
+++ b/src/gs-safety-context-dialog.h
@@ -0,0 +1,31 @@
+/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*-
+ * vi:set noexpandtab tabstop=8 shiftwidth=8:
+ *
+ * Copyright (C) 2021 Endless OS Foundation LLC
+ *
+ * Author: Philip Withnall <pwithnall endlessos org>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#pragma once
+
+#include <glib.h>
+#include <glib-object.h>
+#include <gtk/gtk.h>
+
+#include "gs-app.h"
+
+G_BEGIN_DECLS
+
+#define GS_TYPE_SAFETY_CONTEXT_DIALOG (gs_safety_context_dialog_get_type ())
+
+G_DECLARE_FINAL_TYPE (GsSafetyContextDialog, gs_safety_context_dialog, GS, SAFETY_CONTEXT_DIALOG, HdyWindow)
+
+GsSafetyContextDialog *gs_safety_context_dialog_new (GsApp *app);
+
+GsApp *gs_safety_context_dialog_get_app (GsSafetyContextDialog *self);
+void gs_safety_context_dialog_set_app (GsSafetyContextDialog *self,
+ GsApp *app);
+
+G_END_DECLS
diff --git a/src/gs-safety-context-dialog.ui b/src/gs-safety-context-dialog.ui
new file mode 100644
index 000000000..300d2379b
--- /dev/null
+++ b/src/gs-safety-context-dialog.ui
@@ -0,0 +1,280 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<interface>
+ <requires lib="gtk+" version="3.10"/>
+ <template class="GsSafetyContextDialog" parent="HdyWindow">
+ <property name="modal">True</property>
+ <property name="window_position">center</property>
+ <property name="destroy_with_parent">True</property>
+ <property name="icon_name">dialog-information</property>
+ <property name="title" translatable="yes" comments="Translators: This is the title of the dialog which
contains information about the permissions of an app">Safety</property>
+ <property name="type_hint">dialog</property>
+ <property name="default-width">640</property>
+ <property name="default-height">576</property>
+ <signal name="key-press-event" handler="key_press_event_cb" after="yes" swapped="no"/>
+ <style>
+ <class name="toolbox"/>
+ </style>
+
+ <child>
+ <object class="GtkOverlay">
+ <property name="visible">True</property>
+ <child type="overlay">
+ <object class="HdyHeaderBar">
+ <property name="show_close_button">True</property>
+ <property name="visible">True</property>
+ <property name="valign">start</property>
+ </object>
+ </child>
+ <child>
+ <object class="HdyPreferencesPage">
+ <property name="visible">True</property>
+ <child>
+ <object class="HdyPreferencesGroup">
+ <property name="visible">True</property>
+
+ <child>
+ <object class="GtkBox">
+ <property name="orientation">vertical</property>
+ <property name="spacing">8</property>
+ <property name="visible">True</property>
+
+ <child>
+ <object class="GtkBox">
+ <property name="margin">20</property>
+ <property name="orientation">vertical</property>
+ <property name="spacing">12</property>
+ <property name="visible">True</property>
+
+ <child>
+ <object class="GtkBox" id="lozenge">
+ <property name="halign">center</property>
+ <property name="visible">True</property>
+ <style>
+ <class name="context-tile-lozenge"/>
+ <class name="large"/>
+ <class name="grey"/>
+ </style>
+ <child>
+ <object class="GtkImage" id="icon">
+ <property name="halign">center</property>
+ <!-- this is a placeholder: the icon is actually set in code -->
+ <property name="icon-name">safety-symbolic</property>
+ <property name="visible">True</property>
+ <accessibility>
+ <relation target="title" type="labelled-by"/>
+ </accessibility>
+ </object>
+ <packing>
+ <property name="expand">True</property>
+ </packing>
+ </child>
+ </object>
+ <packing>
+ <property name="fill">False</property>
+ </packing>
+ </child>
+
+ <child>
+ <object class="GtkLabel" id="title">
+ <!-- this is a placeholder: the text is actually set in code -->
+ <property name="justify">center</property>
+ <property name="label">Shortwave is safe</property>
+ <property name="visible">True</property>
+ <property name="wrap">True</property>
+ <property name="xalign">0.5</property>
+ <style>
+ <class name="heading"/>
+ <class name="title-1"/>
+ </style>
+ <accessibility>
+ <relation target="lozenge" type="label-for"/>
+ </accessibility>
+ <style>
+ <class name="context-tile-title"/>
+ </style>
+ </object>
+ </child>
+ </object>
+ </child>
+
+ <child>
+ <object class="GtkListBox" id="permissions_list">
+ <property name="visible">True</property>
+ <property name="selection_mode">none</property>
+ <property name="halign">fill</property>
+ <property name="valign">start</property>
+ <style>
+ <class name="content"/>
+ </style>
+ <!-- Rows are added in code -->
+ <placeholder/>
+ </object>
+ </child>
+
+ <child>
+ <object class="HdyPreferencesGroup">
+ <property name="margin-top">20</property>
+ <property name="title" translatable="yes">Details</property>
+ <property name="visible">True</property>
+
+ <child>
+ <object class="GtkListBox" id="details_list">
+ <property name="visible">True</property>
+ <property name="selection_mode">none</property>
+ <property name="halign">fill</property>
+ <property name="valign">start</property>
+ <style>
+ <class name="content"/>
+ </style>
+
+ <child>
+ <object class="GtkListBoxRow">
+ <property name="visible">True</property>
+ <property name="activatable">False</property>
+ <child>
+ <object class="GtkBox">
+ <property name="visible">True</property>
+ <property name="margin">12</property>
+ <property name="orientation">horizontal</property>
+ <property name="spacing">12</property>
+ <child>
+ <object class="GtkLabel" id="license_title">
+ <property name="ellipsize">end</property>
+ <property name="hexpand">True</property>
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="yalign">0.5</property>
+ <property name="label" translatable="yes">License</property>
+ <accessibility>
+ <relation target="license_label" type="label-for"/>
+ </accessibility>
+ </object>
+ </child>
+ <child>
+ <object class="GtkLabel" id="license_label">
+ <property name="ellipsize">end</property>
+ <property name="valign">center</property>
+ <property name="visible">True</property>
+ <!-- This is a placeholder. The label is set in code. -->
+ <property name="label">GNU GPL v3+</property>
+ <style>
+ <class name="dim-label"/>
+ </style>
+ <accessibility>
+ <relation target="license_title" type="labelled-by"/>
+ </accessibility>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+
+ <child>
+ <object class="GtkListBoxRow">
+ <property name="visible">True</property>
+ <property name="activatable">False</property>
+ <child>
+ <object class="GtkBox">
+ <property name="margin">12</property>
+ <property name="visible">True</property>
+ <property name="orientation">horizontal</property>
+ <property name="spacing">12</property>
+ <child>
+ <object class="GtkLabel" id="source_title">
+ <property name="ellipsize">end</property>
+ <property name="hexpand">True</property>
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="yalign">0.5</property>
+ <property name="label" translatable="yes" comments="Translators:
This is a heading for a row showing the origin/source of an app (such as ‘flathub’).">Source</property>
+ <accessibility>
+ <relation target="source_label" type="label-for"/>
+ </accessibility>
+ </object>
+ </child>
+ <child>
+ <object class="GtkLabel" id="source_label">
+ <property name="ellipsize">end</property>
+ <property name="valign">center</property>
+ <property name="visible">True</property>
+ <!-- This is a placeholder. The label is set in code. -->
+ <property name="label">flathub.org</property>
+ <style>
+ <class name="dim-label"/>
+ </style>
+ <accessibility>
+ <relation target="source_title" type="labelled-by"/>
+ </accessibility>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+
+ <child>
+ <object class="GtkListBoxRow" id="sdk_row">
+ <property name="visible">True</property>
+ <property name="activatable">False</property>
+ <child>
+ <object class="GtkBox">
+ <property name="margin">12</property>
+ <property name="visible">True</property>
+ <property name="orientation">horizontal</property>
+ <property name="spacing">12</property>
+ <child>
+ <object class="GtkLabel" id="sdk_title">
+ <property name="ellipsize">end</property>
+ <property name="hexpand">True</property>
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="yalign">0.5</property>
+ <property name="label" translatable="yes">SDK</property>
+ <accessibility>
+ <relation target="sdk_label" type="label-for"/>
+ </accessibility>
+ </object>
+ </child>
+ <child>
+ <object class="GtkLabel" id="sdk_label">
+ <property name="ellipsize">end</property>
+ <property name="valign">center</property>
+ <property name="visible">True</property>
+ <!-- This is a placeholder. The label is set in code. -->
+ <property name="label">GNOME 3.36.12</property>
+ <style>
+ <class name="dim-label"/>
+ </style>
+ <accessibility>
+ <relation target="sdk_title" type="labelled-by"/>
+ </accessibility>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </object>
+ </child>
+ </template>
+
+ <object class="GtkSizeGroup" id="details_size_group">
+ <property name="mode">horizontal</property>
+ <widgets>
+ <widget name="license_title"/>
+ <widget name="source_title"/>
+ <widget name="sdk_title"/>
+ </widgets>
+ </object>
+</interface>
diff --git a/src/meson.build b/src/meson.build
index ee9056356..51af9845e 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -66,6 +66,7 @@ gnome_software_sources = [
'gs-review-histogram.c',
'gs-review-row.c',
'gs-rounded-bin.c',
+ 'gs-safety-context-dialog.c',
'gs-screenshot-carousel.c',
'gs-screenshot-image.c',
'gs-search-page.c',
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
